Skip to content

vsock/virtio: SKB allocation improvements

Will Deacon lkml netdev stable virtualization 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 14 repliesIn review
  2. v39 patches 9 repliesSuperseded
  3. v28 patches 12 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches14 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9vhost/vsock: Avoid allocating arbitrarily-sized SKBsdrivers/vhost/vsock.c+4 -22 replies
2/9vsock/virtio: Validate length in packet header before skb_put()net/vmw_vsock/virtio_transport.c+10 -21 reply
3/9vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put()drivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c+6 -90 replies
4/9vsock/virtio: Resize receive buffers so that each SKB fits in a 4K pageinclude/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c+7 -23 replies
5/9vsock/virtio: Rename virtio_vsock_alloc_skb()drivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c +1 more+5 -40 replies
6/9vsock/virtio: Move SKB allocation lower-bound check to callersdrivers/vhost/vsock.c include/linux/virtio_vsock.h+2 -40 replies
7/9vhost/vsock: Allocate nonlinear SKBs for handling large receive buffersdrivers/vhost/vsock.c include/linux/virtio_vsock.h+36 -120 replies
8/9vsock/virtio: Rename virtio_vsock_skb_rx_put()drivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c+3 -30 replies
9/9vsock/virtio: Allocate nonlinear SKBs for handling large transmit buffersnet/vmw_vsock/virtio_transport_common.c+3 -25 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefano GarzarellaMichael S. Tsirkin
SeriesA-b
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] vsock/virtio: SKB allocation improvements

Hi all,

Here is version four of the patches I previously posted here:

v1: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]
v3: https://lore.kernel.org/r/[email protected]

There are only two minor changes since v3:

* Use unlikely() in payload length check on the virtio rx path

* Add R-b tags from Stefano

Cheers,

Will

Cc Keir Fraser <[email protected]>
Cc Steven Moreland <[email protected]>
Cc Frederick Mayle <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Cc Stefano Garzarella <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Jason Wang <[email protected]>
Cc "Eugenio Pérez" <[email protected]>

--->8

Will Deacon (9):
vhost/vsock: Avoid allocating arbitrarily-sized SKBs vsock/virtio: Validate length in packet header before skb_put() vsock/virtio: Move length check to callers of
virtio_vsock_skb_rx_put()
vsock/virtio: Resize receive buffers so that each SKB fits in a 4K
page
vsock/virtio: Rename virtio_vsock_alloc_skb() vsock/virtio: Move SKB allocation lower-bound check to callers vhost/vsock: Allocate nonlinear SKBs for handling large receive
buffers
vsock/virtio: Rename virtio_vsock_skb_rx_put() vsock/virtio: Allocate nonlinear SKBs for handling large transmit
buffers

 drivers/vhost/vsock.c                   | 15 ++++----
 include/linux/virtio_vsock.h            | 46 +++++++++++++++++++------
 net/vmw_vsock/virtio_transport.c        | 20 ++++++++---
 net/vmw_vsock/virtio_transport_common.c |  3 +-
 4 files changed, 60 insertions(+), 24 deletions(-)
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog