Skip to content

tmpfs: zero post-eof ranges on file extension

Brian Foster linux-mm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 10 repliesSuperseded
  3. v11 patch 17 repliesSuperseded

Changes in v3 from the cover letter

- Reorder changes in patches 1-2 to factor out existing logic first.
- Use local scope variable in shmem_writeout() fallocend block.
- Tweak combined zeroing logic in shmem_writeout().
- Clean up commit logs.
v2: https://lore.kernel.org/linux-mm/[email protected]/
- Rework to zero uptodate post-eof folios on writeout and full range from EOF on size extension.
- Misc. cleanups: variable renames (pos -> end), code relocation, comment cleanups/removal.
- Update commit log to call out POSIX requirement.
v1: https://lore.kernel.org/linux-mm/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tmpfs: factor out folio zeroing logic at writeout timemm/shmem.c+16 -150 replies
2/3tmpfs: zero post-eof folio ranges on swapoutmm/shmem.c+19 -50 replies
3/3tmpfs: zero post-eof ranges on file extensionmm/shmem.c+79 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] tmpfs: zero post-eof ranges on file extension

Hi all,

Apologies for the quicker than expected respin here, but during discussion with Baolin on v2 it became apparent that I factored the first two patches in an unnecessarily confusing way, and I wanted to get that resolved more quickly. Otherwise there are a few smaller changes here that I think are incremental improvements.

Baolin, I left off the R-b tag from v2 just out of caution and how I reworked the first two patches. The end result is mostly similar, but I'd appreciate a quick look before adding that back. Otherwise most of the functionality here should be the same as v2.

Thoughts, reviews, flames appreciated.

Brian

v3:
- Reorder changes in patches 1-2 to factor out existing logic first.
- Use local scope variable in shmem_writeout() fallocend block.
- Tweak combined zeroing logic in shmem_writeout().
- Clean up commit logs.
v2: https://lore.kernel.org/linux-mm/[email protected]/
- Rework to zero uptodate post-eof folios on writeout and full range from EOF on size extension.
- Misc. cleanups: variable renames (pos -> end), code relocation, comment cleanups/removal.
- Update commit log to call out POSIX requirement.
v1: https://lore.kernel.org/linux-mm/[email protected]/

Brian Foster (3):
tmpfs: factor out folio zeroing logic at writeout time
tmpfs: zero post-eof folio ranges on swapout
tmpfs: zero post-eof ranges on file extension

 mm/shmem.c | 135 ++++++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 114 insertions(+), 21 deletions(-)
Signature · 1 line
2.51.1