Fix bio splitting by the crypto fallback code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 13 repliesIn review
- v22 patches 13 repliesSuperseded
- v13 patches 3 repliesSuperseded
Changes in v3 from the cover letter
- Added a patch that optimizes blk_crypto_max_io_size().
- Added three patches that change calling conventions in the crypto fallback code.
- Added a patch to remove crypto_bio_split.
- Moved the blk_crypto_max_io_size() call into get_max_io_size().
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | block: Improve blk_crypto_fallback_split_bio_if_needed()block/ | +3 | 2 replies | |
| 2/7 | block: Split blk_crypto_fallback_split_bio_if_needed()block/ | +15 | 0 replies | |
| 3/7 | block: Modify the blk_crypto_bio_prep() calling conventionblock/ block/ block/ | +18 | 0 replies | |
| 4/7 | block: Modify the blk_crypto_fallback_bio_prep() calling conventionblock/ block/ block/ | +16 | 0 replies | |
| 5/7 | block: Change the blk_crypto_fallback_encrypt_bio() calling conventionblock/ | +9 | 0 replies | |
| 6/7 | block: Rework splitting of encrypted biosblock/ block/ block/ +1 more | +24 | 0 replies | |
| 7/7 | block, crypto: Remove crypto_bio_splitblock/ | +1 | 0 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by.
| Patch | John Garry |
|---|---|
| 1/7 | R-b |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/7] Fix bio splitting by the crypto fallback code
Hi Jens,
When using the crypto fallback code, large bios are split twice. A first time by bio_split_to_limits() and a second time by the crypto fallback code. This causes bios not to be submitted in LBA error and hence triggers write errors for zoned block devices. This patch series fixes this by splitting bios once. Please consider this patch series for the next merge window.
Thanks,
Bart.
Changes compared to v2:
- Added a patch that optimizes blk_crypto_max_io_size().
- Added three patches that change calling conventions in the crypto fallback code.
- Added a patch to remove crypto_bio_split.
- Moved the blk_crypto_max_io_size() call into get_max_io_size().
Changes compared to v1:
- Dropped support for bio-based drivers that do not call bio_split_to_limits().
- Removed the BLK_FEAT_CALLS_BIO_SPLIT_TO_LIMITS and BIO_HAS_BEEN_SPLIT flags.
Bart Van Assche (7):
block: Improve blk_crypto_fallback_split_bio_if_needed()
block: Split blk_crypto_fallback_split_bio_if_needed()
block: Modify the blk_crypto_bio_prep() calling convention
block: Modify the blk_crypto_fallback_bio_prep() calling convention
block: Change the blk_crypto_fallback_encrypt_bio() calling convention
block: Rework splitting of encrypted bios
block, crypto: Remove crypto_bio_split
block/blk-core.c | 3 -- block/blk-crypto-fallback.c | 85 ++++++++++++++----------------------- block/blk-crypto-internal.h | 25 +++++++---- block/blk-crypto.c | 26 ++++++------ block/blk-merge.c | 9 +++- 5 files changed, 68 insertions(+), 80 deletions(-)