Skip to content

drm/i915/dp: Fix few SST HPD IRQ handling issues

Imre Deak intel-gfx intel-xe 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest20 patches 1 replyIn review
  2. v220 patches 1 replySuperseded
  3. v120 patches 39 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20drm/i915/dp_mst: Reprobe connector if the IRQ ESI read faileddrivers/gpu/drm/i915/display/intel_dp.c+1 -10 replies
2/20drm/i915/dp_mst: Verify the link status always the same waydrivers/gpu/drm/i915/display/intel_dp.c+18 -20 replies
3/20drm/i915/dp_mst: Reuse intel_dp_check_link_state() in the HPD IRQ handlerdrivers/gpu/drm/i915/display/intel_dp.c+4 -300 replies
4/20drm/i915/dp: Handle a tunneling IRQ after acking itdrivers/gpu/drm/i915/display/intel_dp.c+12 -150 replies
5/20drm/i915/dp: Handle the RX_CAP_CHANGED HPD IRQdrivers/gpu/drm/i915/display/intel_dp.c+7 -10 replies
6/20drm/i915/dp: Handle the DOWNSTREAM_PORT_STATUS_CHANGED eventdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c+16 -10 replies
7/20drm/i915/dp: Don't clobber the encoder state in the HPD IRQ handlerdrivers/gpu/drm/i915/display/intel_dp.c+2 -60 replies
8/20drm/i915/dp: Remove the device service IRQ handling from connector detectdrivers/gpu/drm/i915/display/intel_dp.c+0 -20 replies
9/20drm/i915/dp: Fix the device service IRQ DPCD_REV checkdrivers/gpu/drm/i915/display/intel_dp.c+0 -30 replies
10/20drm/i915/dp: Fix the link service IRQ DPCD_REV checkdrivers/gpu/drm/i915/display/intel_dp.c+1 -10 replies
11/20drm/i915/dp: Reprobe connector if getting/acking device IRQs failsdrivers/gpu/drm/i915/display/intel_dp.c+19 -60 replies
12/20drm/i915/dp: Reprobe connector if getting/acking link service IRQs failsdrivers/gpu/drm/i915/display/intel_dp.c+10 -20 replies
13/20drm/i915/dp: Return early if getting/acking device service IRQs failsdrivers/gpu/drm/i915/display/intel_dp.c+24 -130 replies
14/20drm/i915/dp: Return early if getting/ackink link service IRQs failsdrivers/gpu/drm/i915/display/intel_dp.c+29 -160 replies
15/20drm/i915/dp: Read/ack sink count and sink IRQs for SST as it's done for MSTdrivers/gpu/drm/i915/display/intel_dp.c+79 -630 replies
16/20drm/i915/dp: Print debug message for a sink connected off requestdrivers/gpu/drm/i915/display/intel_dp.c+8 -00 replies
17/20drm/i915/dp: Check SST link status while handling link service IRQsdrivers/gpu/drm/i915/display/intel_dp.c+9 -20 replies
18/20drm/i915/dp_mst: Reuse intel_dp_handle_link_service_irq()drivers/gpu/drm/i915/display/intel_dp.c+4 -90 replies
19/20drm/i915/dp: Ack only the handled device service IRQsdrivers/gpu/drm/i915/display/intel_dp.c+14 -00 replies
20/20drm/i915/dp: Ack only the handled link service IRQsdrivers/gpu/drm/i915/display/intel_dp.c+16 -10 replies

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchLuca Coelho
1/20R-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20R-b
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/20] drm/i915/dp: Fix few SST HPD IRQ handling issues

This is v3 of [1], which was incorrectly sent without the actual v2 updates, including now the actual v2 updates.

Cc Luca Coelho <[email protected]>
Cc Jani Nikula <[email protected]>

[1] https://lore.kernel.org/all/[email protected]

Imre Deak (20):
drm/i915/dp_mst: Reprobe connector if the IRQ ESI read failed drm/i915/dp_mst: Verify the link status always the same way drm/i915/dp_mst: Reuse intel_dp_check_link_state() in the HPD IRQ
handler
drm/i915/dp: Handle a tunneling IRQ after acking it drm/i915/dp: Handle the RX_CAP_CHANGED HPD IRQ drm/i915/dp: Handle the DOWNSTREAM_PORT_STATUS_CHANGED event drm/i915/dp: Don't clobber the encoder state in the HPD IRQ handler drm/i915/dp: Remove the device service IRQ handling from connector
detect
drm/i915/dp: Fix the device service IRQ DPCD_REV check drm/i915/dp: Fix the link service IRQ DPCD_REV check drm/i915/dp: Reprobe connector if getting/acking device IRQs fails drm/i915/dp: Reprobe connector if getting/acking link service IRQs
fails
drm/i915/dp: Return early if getting/acking device service IRQs fails drm/i915/dp: Return early if getting/acking link service IRQs fails drm/i915/dp: Read/ack sink count and sink IRQs for SST as it's done
for MST
drm/i915/dp: Print debug message for a sink connected off request drm/i915/dp: Check SST link status while handling link service IRQs drm/i915/dp_mst: Reuse intel_dp_handle_link_service_irq() drm/i915/dp: Ack only the handled device service IRQs drm/i915/dp: Ack only the handled link service IRQs

 .../drm/i915/display/intel_display_types.h    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 253 ++++++++++++------
 2 files changed, 171 insertions(+), 83 deletions(-)
Signature · 41 lines
2.49.1








Imre Deak (20):
  drm/i915/dp_mst: Reprobe connector if the IRQ ESI read failed
  drm/i915/dp_mst: Verify the link status always the same way
  drm/i915/dp_mst: Reuse intel_dp_check_link_state() in the HPD IRQ
    handler
  drm/i915/dp: Handle a tunneling IRQ after acking it
  drm/i915/dp: Handle the RX_CAP_CHANGED HPD IRQ
  drm/i915/dp: Handle the DOWNSTREAM_PORT_STATUS_CHANGED event
  drm/i915/dp: Don't clobber the encoder state in the HPD IRQ handler
  drm/i915/dp: Remove the device service IRQ handling from connector
    detect
  drm/i915/dp: Fix the device service IRQ DPCD_REV check
  drm/i915/dp: Fix the link service IRQ DPCD_REV check
  drm/i915/dp: Reprobe connector if getting/acking device IRQs fails
  drm/i915/dp: Reprobe connector if getting/acking link service IRQs
    fails
  drm/i915/dp: Return early if getting/acking device service IRQs fails
  drm/i915/dp: Return early if getting/ackink link service IRQs fails
  drm/i915/dp: Read/ack sink count and sink IRQs for SST as it's done
    for MST
  drm/i915/dp: Print debug message for a sink connected off request
  drm/i915/dp: Check SST link status while handling link service IRQs
  drm/i915/dp_mst: Reuse intel_dp_handle_link_service_irq()
  drm/i915/dp: Ack only the handled device service IRQs
  drm/i915/dp: Ack only the handled link service IRQs

 .../drm/i915/display/intel_display_types.h    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 264 ++++++++++++------
 2 files changed, 182 insertions(+), 83 deletions(-)

-- 
2.49.1