Skip to content

net: ethtool: consistently take rss_lock for all rxfh ops

Jakub Kicinski netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: ethtool: take rss_lock for all rxfh changesnet/ethtool/ioctl.c+21 -210 repliesApplied
2/3net: ethtool: move rxfh_fields callbacks under the rss_lockdrivers/net/ethernet/sfc/ethtool_common.c net/ethtool/ioctl.c+12 -120 repliesApplied
3/3net: ethtool: move get_rxfh callback under the rss_locknet/ethtool/common.c net/ethtool/ioctl.c net/ethtool/rss.c+27 -90 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net: ethtool: consistently take rss_lock for all rxfh ops

I'd like to bring RXFH and RXFHINDIR ioctls under a single set of Netlink ops. It appears that while core takes the ethtool->rss_lock around some of the RXFHINDIR ops, drivers (sfc) take it internally for the RXFH.

Consistently take the lock around all ops and accesses to the XArray within the core. This should hopefully make the rss_lock a lot less confusing.

Jakub Kicinski (3):
net: ethtool: take rss_lock for all rxfh changes
net: ethtool: move rxfh_fields callbacks under the rss_lock
net: ethtool: move get_rxfh callback under the rss_lock

 drivers/net/ethernet/sfc/ethtool_common.c |  9 +---
 net/ethtool/common.c                      |  2 +
 net/ethtool/ioctl.c                       | 66 +++++++++++++----------
 net/ethtool/rss.c                         | 23 +++++---
 4 files changed, 59 insertions(+), 41 deletions(-)
Signature · 1 line
2.50.0