Skip to content

ppp: Replace per-CPU recursion counter with lock-owner field

Sebastian Andrzej Siewior linux-ppp linux-rt-devel netdev 3 versions – Applied

Status from this message: This patch was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 2 repliesApplied 1/1
  2. v21 patch 3 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Patches in v3 All 1 applied

#Subject and filesSizeRepliesApplied
1/1ppp: Replace per-CPU recursion counter with lock-owner fielddrivers/net/ppp/ppp_generic.c+29 -90 repliesApplied

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGuillaume Nault
SeriesR-b
1/1

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/1] ppp: Replace per-CPU recursion counter with lock-owner field

This is another approach to avoid relying on local_bh_disable() for locking of per-CPU in ppp.

I redid it with the per-CPU lock and local_lock_nested_bh() as discussed in v1. The xmit_recursion counter has been removed since it served the same purpose as the owner field. Both were updated and checked.

The xmit_recursion looks like a counter in ppp_channel_push() but at this point, the counter should always be 0 so it always serves as a boolean. Therefore I removed it.

I do admit that this looks easier to review.

v2…v3 https://lore.kernel.org/all/[email protected]/
- rebase on top of net-next
- replace "ppp channel" with "ppp unit" in the patch description

v1…v2 https://lore.kernel.org/all/[email protected]/
- Instead of rewriting the sequence and adding two owner fields to the two variables that may recurse it now adds a per-CPU variable for locking and keeping mostly the old code flow.

Sebastian Andrzej Siewior (1):
ppp: Replace per-CPU recursion counter with lock-owner field

 drivers/net/ppp/ppp_generic.c | 38 ++++++++++++++++++++++++++---------
 1 file changed, 29 insertions(+), 9 deletions(-)
Signature · 1 line
2.50.0