Skip to content

mm: folio_pte_batch() improvements

David Hildenbrand linux-mm lkml 2 versions – Applied

Status from this message: [merged mm-stable] mm-remove-boolean-output-parameters-from-folio_pte_batch_ext.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 12 repliesApplied 4/4
  2. v14 patches 53 repliesSuperseded

Changes in v2 from the cover letter

* Use FPB_RESPECT_* instead of FPB_HONOR_*
* Use folio_pte_batch_flags() instead of folio_pte_batch_ext()
* Improvements to patch descriptions + comments/doc

Patches in v2 All 4 applied

#Subject and filesSizeRepliesApplied
1/4mm: convert FPB_IGNORE_* into FPB_RESPECT_*mm/internal.h mm/madvise.c mm/memory.c +4 more+18 -251 replyApplied
2/4mm: smaller folio_pte_batch() improvementsmm/internal.h+15 -222 repliesApplied
3/4mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_flags()mm/internal.h mm/madvise.c mm/memory.c +5 more+46 -182 repliesApplied
4/4mm: remove boolean output parameters from folio_pte_batch_ext()mm/internal.h mm/madvise.c mm/memory.c +1 more+50 -517 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchLance YangZi YanOscar SalvadorLorenzo StoakesDev Jain
1/4R-b R-b R-b R-b
2/4R-b R-b R-b R-b R-b
3/4R-b R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] mm: folio_pte_batch() improvements

Ever since we added folio_pte_batch() for fork() + munmap() purposes, a lot more users appeared (and more are being proposed), and more functionality was added.

Most of the users only need basic functionality, and could benefit from a non-inlined version.

So let's clean up folio_pte_batch() and split it into a basic folio_pte_batch() (no flags) and a more advanced folio_pte_batch_ext(). Using either variant will now look much cleaner.

This series will likely conflict with some changes in some (old+new) folio_pte_batch() users, but conflicts should be trivial to resolve.

Tested on x86-64. Cross-compile tested.

v1 -> v2:
* Use FPB_RESPECT_* instead of FPB_HONOR_*
* Use folio_pte_batch_flags() instead of folio_pte_batch_ext()
* Improvements to patch descriptions + comments/doc

Cc Andrew Morton <[email protected]>
Cc "Liam R. Howlett" <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Jann Horn <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Zi Yan <[email protected]>
Cc Matthew Brost <[email protected]>
Cc Joshua Hahn <[email protected]>
Cc Rakie Kim <[email protected]>
Cc Byungchul Park <[email protected]>
Cc Gregory Price <[email protected]>
Cc Ying Huang <[email protected]>
Cc Alistair Popple <[email protected]>
Cc Pedro Falcato <[email protected]>
Cc Rik van Riel <[email protected]>
Cc Harry Yoo <[email protected]>
Cc Lance Yang <[email protected]>
Cc Oscar Salvador <[email protected]>

David Hildenbrand (4):
mm: convert FPB_IGNORE_* into FPB_RESPECT_*
mm: smaller folio_pte_batch() improvements
mm: split folio_pte_batch() into folio_pte_batch() and
folio_pte_batch_flags()
mm: remove boolean output parameters from folio_pte_batch_ext()

 mm/internal.h  | 117 ++++++++++++++++++++++++++++---------------------
 mm/madvise.c   |  27 +++---------
 mm/memory.c    |  21 +++------
 mm/mempolicy.c |   5 +--
 mm/mlock.c     |   4 +-
 mm/mremap.c    |   4 +-
 mm/rmap.c      |   4 +-
 mm/util.c      |  29 ++++++++++++
 8 files changed, 112 insertions(+), 99 deletions(-)

base-commit: 01136079697c6686e7198bf1797c004767ecf6f1

Signature · 1 line
2.49.0