Skip to content

target/alpha: Add TCG plugin register tracking support

Yodel Eldar qemu-devel 2 versions – Applied

Status from this message: Queued to plugins/next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesApplied
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- As suggested by Alex Bennée, replaced strpbrk with g_strsplit_set

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2contrib/plugins/execlog: Add tab to the separator search of insn_disascontrib/plugins/execlog.c+9 -60 replies
2/2target/alpha: Add GDB XML feature fileconfigs/targets/alpha-linux-user.mak configs/targets/alpha-softmmu.mak gdb-xml/alpha-core.xml +1 more+139 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRichard Henderson
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] target/alpha: Add TCG plugin register tracking support

This patch adds TCG plugin register tracking support for the Alpha target and resolves gitlab issue #2569:

https://gitlab.com/qemu-project/qemu/-/issues/2569

As mentioned in the bug report by Alex Bennée, the register list is built using the target's corresponding GDB XML feature file, but the Alpha target does not have one. The second patch introduces the missing feature file and the necessary plumbing for it.

While testing the second patch, I noticed the following error:

qemu-alpha: GLib: g_strrstr: assertion 'haystack != NULL' failed

when running:

  ./qemu-alpha -d plugin \
  -plugin ./contrib/plugins/libexeclog.so,reg=*,rdisas=on \
  ./tests/tcg/alpha-linux-user/linux-test

and discovered an issue with execlog.c that the first patch resolves:
a missing null check after execlog searches a disassembled instruction for a space separator between the mnemonic and the operands. Execlog assumes that disassembled instructions will contain a space, but some disassemblers use tabs (like Alpha).

Besides adding the null check, the execlog patch also adds tab to the separator search by replacing the g_strstr_len call with a call to g_strsplit_set, so that the plugin would operate as intended for Alpha.

A pointer in the immediate area of the changed code is converted to a const pointer in keeping with the QEMU Coding Style. Also, as a trivial optimization, I took the liberty of adding a break statement to the register search loop that immediately follows the separator search, so that it breaks out of the loop as soon as a relevant register is found in the instruction.

Patch Series History:
v1 -> v2:
- As suggested by Alex Bennée, replaced strpbrk with g_strsplit_set

Yodel Eldar (2):
contrib/plugins/execlog: Add tab to the separator search of insn_disas target/alpha: Add GDB XML feature file

 configs/targets/alpha-linux-user.mak |   1 +
 configs/targets/alpha-softmmu.mak    |   1 +
 contrib/plugins/execlog.c            |  15 +--
 gdb-xml/alpha-core.xml               | 136 +++++++++++++++++++++++++++
 target/alpha/cpu.c                   |   1 +
 5 files changed, 148 insertions(+), 6 deletions(-)
 create mode 100644 gdb-xml/alpha-core.xml
Signature · 1 line
2.50.0