Skip to content

Improve link power management

Damien Le Moal linux-ide 3 versions – Applied

Status from this message: Applied to libata/linux.git (for-6.17), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 2 repliesApplied
  2. v210 patches 3 repliesSuperseded
  3. v110 patches 28 repliesSuperseded

Changes in v3 from the cover letter

- Improved comments in ata_dev_config_lpm() and the commit message of patch 1
- Improved commit message of patch 7
- Added review tags

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10ata: libata-core: Introduce ata_dev_config_lpm()drivers/ata/libata-core.c+25 -01 reply
2/10ata: libata-core: Move device LPM quirk settings to ata_dev_config_lpm()drivers/ata/libata-core.c+26 -170 replies
3/10ata: libata-core: Advertize device support for DIPM and HIPM featuresdrivers/ata/libata-core.c+3 -10 replies
4/10ata: libata-eh: Avoid unnecessary resets when revalidating devicesdrivers/ata/libata-eh.c+28 -10 replies
5/10ata: libata-sata: Disallow changing LPM state if not supporteddrivers/ata/libata-sata.c+5 -00 replies
6/10ata: ahci: Disable DIPM if host lacks supportdrivers/ata/ahci.c+7 -00 replies
7/10ata: ahci: Disallow LPM policy control for external portsdrivers/ata/ahci.c+2 -10 replies
8/10ata: ahci: Disallow LPM policy control if not supporteddrivers/ata/ahci.c+4 -10 replies
9/10ata: libata-core: Reduce the number of messages signaling broken LPMdrivers/ata/libata-core.c+2 -10 replies
10/10ata: libata_eh: Add debug messages to ata_eh_link_set_lpm()drivers/ata/libata-eh.c+2 -00 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchNiklas CasselHannes Reinecke
1/10R-b R-b
2/10R-b R-b
3/10R-b R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b R-b
7/10R-b R-b
8/10R-b R-b
9/10R-b R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] Improve link power management

This patch series improves ATA link power management, mainly for the AHCI driver. Follow-up patches will address libsas and AHCI platform adapters.

These patches are a mix of code cleanup and LPM management improvements around the application of an appropriate initial link power management policy and preventing users or system daemons from changing a port link power management policy through sysfs when the port or the device does not support LPM policies or the port is an external port (and using LPM would break the port hotplug capability).

Changes from v2:
- Improved comments in ata_dev_config_lpm() and the commit message of patch 1
- Improved commit message of patch 7
- Added review tags

Changes from v1:
- Improved commit message of patch 1 as suggested by Niklas.
- Removed warning message in patch 7.
- Changed warning message in patch 8 to be a debug message. Also fixed a typo in the commit message.
- Changed message to be a single line in patch 10.

Damien Le Moal (10):
ata: libata-core: Introduce ata_dev_config_lpm()
ata: libata-core: Move device LPM quirk settings to ata_dev_config_lpm()
ata: libata-core: Advertize device support for DIPM and HIPM features
ata: libata-eh: Avoid unnecessary resets when revalidating devices
ata: libata-sata: Disallow changing LPM state if not supported
ata: ahci: Disable DIPM if host lacks support
ata: ahci: Disallow LPM policy control for external ports
ata: ahci: Disallow LPM policy control if not supported
ata: libata-core: Reduce the number of messages signaling broken LPM
ata: libata_eh: Add debug messages to ata_eh_link_set_lpm()

 drivers/ata/ahci.c        | 15 ++++++--
 drivers/ata/libata-core.c | 73 +++++++++++++++++++++++++++++----------
 drivers/ata/libata-eh.c   | 31 ++++++++++++++++-
 drivers/ata/libata-sata.c |  5 +++
 4 files changed, 103 insertions(+), 21 deletions(-)
Signature · 1 line
2.50.0