Skip to content

Allow injection of virtio-gpu EDID name

Andrew Keesler qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest1 patch 1 replyIn review
  2. v51 patch 2 repliesSuperseded
  3. v41 patch 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v31 patch0 repliesSuperseded
v21 patch1 replySuperseded

Changelog from the cover letter

* v6 - minor code cleanup: really fix JSON syntax
* v5 - minor code cleanup: JSON syntax, QAPI "Since", control flow
* v4 - fixed copy-paste issue in virtio_gpu_base_generate_edid()
* v3 - report an error at realize time if request name is too long
* v2 - migrated configuration surface to virtio-gpu device

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1hw/display: Allow injection of virtio-gpu EDID namehw/core/qdev-properties-system.c hw/display/virtio-gpu-base.c include/hw/display/edid.h +3 more+97 -21 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchMarc-André Lureau
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/1] Allow injection of virtio-gpu EDID name

Thanks to 72d277a7, 1ed2cb32, and others, EDID (Extended Display Identification Data) is propagated by QEMU such that a virtual display presents legitimate metadata (e.g., name, serial number, preferred resolutions, etc.) to its connected guest.

This change adds the ability to specify the EDID name for a particular virtio-vga display. Previously, every virtual display would have the same
name: "QEMU Monitor". Now, we can inject names of displays in order to test guest behavior that is specific to display names. We provide the ability to inject the display name from the frontend since this is guest visible data. Furthermore, this makes it clear where N potential display outputs would get their name from (which will be added in a future change).

Note that we have elected to use a struct here for output data for extensibility - we intend to add per-output fields like resolution in a future change.

It should be noted that EDID names longer than 12 bytes will be truncated per spec (I think?).

Testing: verified that when I specified 2 outputs for a virtio-gpu with edid_name set, the names matched those that I configured with my vnc display.

  -display vnc=localhost:0,id=aaa,display=vga,head=0 \
  -display vnc=localhost:1,id=bbb,display=vga,head=1 \
  -device '{"driver":"virtio-vga",
            "max_outputs":2,
            "id":"vga",
            "outputs":[
              {
                 "name":"AAA"
              },
              {
                 "name":"BBB"
              }
            ]}'

Changelog:
* v6 - minor code cleanup: really fix JSON syntax
* v5 - minor code cleanup: JSON syntax, QAPI "Since", control flow
* v4 - fixed copy-paste issue in virtio_gpu_base_generate_edid()
* v3 - report an error at realize time if request name is too long
* v2 - migrated configuration surface to virtio-gpu device

Andrew Keesler (1):
hw/display: Allow injection of virtio-gpu EDID name

 hw/core/qdev-properties-system.c    | 44 +++++++++++++++++++++++++++++
 hw/display/virtio-gpu-base.c        | 27 ++++++++++++++++++
 include/hw/display/edid.h           |  2 ++
 include/hw/qdev-properties-system.h |  5 ++++
 include/hw/virtio/virtio-gpu.h      |  3 ++
 qapi/virtio.json                    | 18 ++++++++++--
 6 files changed, 97 insertions(+), 2 deletions(-)
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog