Skip to content

net: migrate remaining drivers to dedicated _rxfh_context ops

Jakub Kicinski netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 5 repliesApplied 5/5
  2. v25 patches 5 repliesSuperseded
  3. v15 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- [mlx5] fix compilation
- [patch 4] remove more branches
- [patch 5] reformat
v2: https://lore.kernel.org/[email protected]
- [mlx5] remove hfunc local var in mlx5e_rxfh_hfunc_check()
- [mlx5] make the get functions void and add WARN_ON_ONCE()
- [patch 4] remove rxfh struct in netdev_rss_contexts_free()
v1: https://lore.kernel.org/[email protected]

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5eth: otx2: migrate to the *_rxfh_context opsdrivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c +2 more+90 -921 replyApplied
2/5eth: ice: drop the dead code related to rss_contextsdrivers/net/ethernet/intel/ice/ice_ethtool.c+3 -251 replyApplied
3/5eth: mlx5: migrate to the *_rxfh_context opsdrivers/net/ethernet/mellanox/mlx5/core/en/rss.c drivers/net/ethernet/mellanox/mlx5/core/en/rss.h drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c +2 more+130 -601 replyApplied
4/5net: ethtool: remove the compat code for _rxfh_context opsinclude/linux/ethtool.h net/core/dev.c net/ethtool/ioctl.c +1 more+16 -711 replyApplied
5/5net: ethtool: reduce indent for _rxfh_context opsnet/ethtool/ioctl.c+12 -181 replyApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchGeetha SowjanyaGal PressmanEdward CreeSimon Horman
1/5T-b R-b
2/5R-b
3/5R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] net: migrate remaining drivers to dedicated _rxfh_context ops

Around a year ago Ed added dedicated ops for managing RSS contexts. This significantly improved the clarity of the driver facing API. Migrate the remaining 3 drivers and remove the old way of muxing the RSS context operations via .set_rxfh().

v3:
- [mlx5] fix compilation
- [patch 4] remove more branches
- [patch 5] reformat
v2: https://lore.kernel.org/[email protected]
- [mlx5] remove hfunc local var in mlx5e_rxfh_hfunc_check()
- [mlx5] make the get functions void and add WARN_ON_ONCE()
- [patch 4] remove rxfh struct in netdev_rss_contexts_free()
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (5):
eth: otx2: migrate to the *_rxfh_context ops
eth: ice: drop the dead code related to rss_contexts
eth: mlx5: migrate to the *_rxfh_context ops
net: ethtool: remove the compat code for _rxfh_context ops
net: ethtool: reduce indent for _rxfh_context ops

 .../marvell/octeontx2/nic/otx2_common.h       |   8 +-
 .../net/ethernet/mellanox/mlx5/core/en/rss.h  |   3 +-
 .../ethernet/mellanox/mlx5/core/en/rx_res.h   |   7 +-
 include/linux/ethtool.h                       |   4 -
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |  28 +---
 .../marvell/octeontx2/nic/otx2_common.c       |  27 ++--
 .../marvell/octeontx2/nic/otx2_ethtool.c      | 137 +++++++++--------
 .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |   6 +-
 .../ethernet/marvell/octeontx2/nic/otx2_xsk.c |   4 +-
 .../net/ethernet/mellanox/mlx5/core/en/rss.c  |   5 +-
 .../ethernet/mellanox/mlx5/core/en/rx_res.c   |  30 ++--
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  | 145 ++++++++++++++----
 net/core/dev.c                                |  15 +-
 net/ethtool/ioctl.c                           |  93 +++--------
 net/ethtool/rss.c                             |   3 +-
 15 files changed, 250 insertions(+), 265 deletions(-)
Signature · 1 line
2.50.0