Skip to content

ibmvnic: Fix/Improve queue stats

Mingming Cao netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/22 patches 3 repliesIn review
  2. v3 posting 1/22 patches 1 replySuperseded
  3. v24 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches2 repliesSuperseded

Changes in v3 from the cover letter

link to v2: https://www.spinics.net/lists/netdev/msg1104665.html

- Dropped Patch 2 from v2, which fixed the hardcoded NUM_RX_STATS and NUM_TX_STATS, as suggested by Simon. https://www.spinics.net/lists/netdev/msg1106669.html included in net-next
- Updated Patch 1 in v2 to rebase on top of the above fix in net.
– Patch 3 in v2 (now patch 2) unchanged.
- Dropped Patch 4 from v2, which raised the default number of indirect sub-CRQ entries and introduced a module parameter for backward compatibility. Based on review feedback, plan to explore alternative ways to handle older systems without adding a module parameter.

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ibmvnic: Use atomic64_t for queue statsdrivers/net/ethernet/ibm/ibmvnic.c drivers/net/ethernet/ibm/ibmvnic.h+34 -262 replies
2/2ibmvnic: Use ndo_get_stats64 to fix inaccurate SAR reportingdrivers/net/ethernet/ibm/ibmvnic.c+21 -81 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBrian KingDave MarquardtSimon Horman
1/2R-b R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 net-next resubmit 0/2] ibmvnic: Fix/Improve queue stats

This series is resubmitted after the bug fix for hardcoded NUM_RX_STATS and NUM_TX_STATS has already been included in the net-next tree.

This patch series introduces two updates to the ibmvnic driver, focusing on improving the accuracy and safety of queue-level statistics.

Patch 1: Convert per-queue RX/TX stats to atomic64_t to ensure thread-safe updates in concurrent environments. This establishes a safe and consistent foundation for subsequent statistics-related fixes.

Patch 2: Fix inaccurate sar statistics by implementing ndo_get_stats64() and removing the outdated manual updates to netdev->stats. This patch also improves packets rates and bandwith with large workload.

--------------------------------------

Changes since v2:
link to v2: https://www.spinics.net/lists/netdev/msg1104665.html

- Dropped Patch 2 from v2, which fixed the hardcoded NUM_RX_STATS and NUM_TX_STATS, as suggested by Simon. https://www.spinics.net/lists/netdev/msg1106669.html included in net-next
- Updated Patch 1 in v2 to rebase on top of the above fix in net.
– Patch 3 in v2 (now patch 2) unchanged.
- Dropped Patch 4 from v2, which raised the default number of indirect sub-CRQ entries and introduced a module parameter for backward compatibility. Based on review feedback, plan to explore alternative ways to handle older systems without adding a module parameter.

---

Changes since v1:
Link to v1: https://www.spinics.net/lists/netdev/msg1103893.html

Patch 1 (was Patch 2 in v1): Introduces atomic64_t stats early to establish a consistent foundation. Replaces atomic64_sub() with atomic64_sub_return() and adds a warning for underflow. This change now comes first to ensure correct
ordering of dependency with stat size derivation.

Patch 2 (was Patch 1 in v1): Commit message rewritten to clearly highlight the mismatch bug caused by static stat counts and rebased on top of the atomic64 conversion to avoid broken logic during intermediate states.

Patch 3: No functional changes

Patch 4: Commit message clarified to explain the use of 128 indirect entries on POWER9+ systems and the intent of the module parameter as a transitional fallback for legacy or constrained systems.

Mingming Cao (2):
ibmvnic: Use atomic64_t for queue stats
ibmvnic: Use ndo_get_stats64 to fix inaccurate SAR reporting

 drivers/net/ethernet/ibm/ibmvnic.c | 71 +++++++++++++++++++-----------
 drivers/net/ethernet/ibm/ibmvnic.h | 18 ++++----
 2 files changed, 55 insertions(+), 34 deletions(-)
Signature · 1 line
2.39.3 (Apple Git-146)