Skip to content

atm: clip: Fix infinite recursion, potential null-ptr-deref, and memleak.

Kuniyuki Iwashima netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesApplied 3/3
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

* Add patch 2
* Patch 1: Silence Sparse __rcu warning

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3atm: clip: Fix potential null-ptr-deref in to_atmarpd().net/atm/clip.c+29 -151 replyApplied
2/3atm: clip: Fix memory leak of struct clip_vcc.net/atm/clip.c+8 -01 replyApplied
3/3atm: clip: Fix infinite recursive call of clip_push().net/atm/clip.c+2 -01 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSimon Horman
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net 0/3] atm: clip: Fix infinite recursion, potential null-ptr-deref, and memleak.

Patch 1 fixes racy access to atmarpd found while checking RTNL usage in clip.c.

Patch 2 fixes memory leak by ioctl(ATMARP_MKIP) and ioctl(ATMARPD_CTRL).

Patch 3 fixes infinite recursive call of clip_vcc->old_push(), which was reported by syzbot.

Changes:
v2:
* Add patch 2
* Patch 1: Silence Sparse __rcu warning

v1: https://lore.kernel.org/netdev/[email protected]/

Kuniyuki Iwashima (3):
atm: clip: Fix potential null-ptr-deref in to_atmarpd().
atm: clip: Fix memory leak of struct clip_vcc.
atm: clip: Fix infinite recursive call of clip_push().

 net/atm/clip.c | 54 ++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 39 insertions(+), 15 deletions(-)
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog