Skip to content

Input: Add BTN_GRIP*

Vicki Pfau linux-input 2 versions – Applied

Status from this message: Applied, thank you.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v13 patches 1 replyApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3Input: Add and document BTN_GRIP*Documentation/input/gamepad.rst drivers/hid/hid-debug.c include/uapi/linux/input-event-codes.h+20 -00 replies
2/3Input - xpad: Use new BTN_GRIP* buttonsdrivers/input/joystick/xpad.c+18 -181 reply
3/3HID: hid-steam: Use new BTN_GRIP* buttonsdrivers/hid/hid-steam.c+16 -191 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchJiri Kosina
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Input: Add BTN_GRIP*

Many controllers these days have started including grip buttons. As there has been no particular assigned BTN_* constants for these, they've been hapharzardly assigned to BTN_TRIGGER_HAPPY*. Unfortunately, the assignemnt of these has varied significantly between drivers.

This series adds, documents, and uses those buttons in the xpad and hid-steam drivers. The only other driver I was able to find that supports grip buttons was the BPF patch for the Xbox Elite 2 controller. Unfortunately, I'm not sure how to clean that up and add support in HID descriptor parsing, so I'll have to leave that to Benjamin.

Version 2 changes the hid-steam patch to use BTN_GRIPL/BTN_GRIPR for the Steam Controller, not just the Steam Deck. All other patches are unchanged.

Vicki Pfau (3):
Input: Add and document BTN_GRIP*
Input - xpad: Use new BTN_GRIP* buttons
HID: hid-steam: Use new BTN_GRIP* buttons

 Documentation/input/gamepad.rst        | 13 ++++++++++
 drivers/hid/hid-debug.c                |  2 ++
 drivers/hid/hid-steam.c                | 35 ++++++++++++-------------
 drivers/input/joystick/xpad.c          | 36 +++++++++++++-------------
 include/uapi/linux/input-event-codes.h |  5 ++++
 5 files changed, 54 insertions(+), 37 deletions(-)
Signature · 1 line
2.49.0