ublk: cleanup for supporting batch IO command
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest17 patches 7 repliesApplied
- v216 patches 6 repliesSuperseded
- v116 patches 12 repliesSuperseded
Changes in v3 from the cover letter
- add patch "ublk: validate ublk server pid"
- clean "ublk: let ublk_fill_io_cmd() cover more things" by not setting io->res in ublk_fill_io_cmd()
- improve commit log
- misc patch style fix
- add reviewed-by tag
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | ublk: validate ublk server piddrivers/ | +9 | 4 replies | |
| 2/17 | ublk: look up ublk task via its pid in timeout handlerdrivers/ | +17 | 0 replies | |
| 3/17 | ublk: move fake timeout logic into __ublk_complete_rq()drivers/ | +1 | 0 replies | |
| 4/17 | ublk: let ublk_fill_io_cmd() cover more thingsdrivers/ | +2 | 1 reply | |
| 5/17 | ublk: avoid to pass `struct ublksrv_io_cmd *` to ublk_commit_and_fetch()drivers/ | +29 | 0 replies | |
| 6/17 | ublk: move auto buffer register handling into one dedicated helperdrivers/ | +71 | 0 replies | |
| 7/17 | ublk: store auto buffer register data into `struct ublk_io`drivers/ | +12 | 0 replies | |
| 8/17 | ublk: add helper ublk_check_fetch_buf()drivers/ | +19 | 0 replies | |
| 9/17 | ublk: remove ublk_commit_and_fetch()drivers/ | +18 | 1 reply | |
| 10/17 | ublk: pass 'const struct ublk_io *' to ublk_[un]map_io()drivers/ | +2 | 0 replies | |
| 11/17 | selftests: ublk: remove `tag` parameter of ->tgt_io_done()tools/ tools/ tools/ +3 more | +10 | 0 replies | |
| 12/17 | selftests: ublk: pass 'ublk_thread *' to ->queue_io() and ->tgt_io_done()tools/ tools/ tools/ +3 more | +58 | 0 replies | |
| 13/17 | selftests: ublk: pass 'ublk_thread *' to more common helperstools/ tools/ tools/ +3 more | +28 | 0 replies | |
| 14/17 | selftests: ublk: remove ublk queue self-defined flagstools/ tools/ tools/ | +25 | 0 replies | |
| 15/17 | selftests: ublk: improve flags namingtools/ tools/ | +29 | 0 replies | |
| 16/17 | selftests: ublk: add helper ublk_handle_uring_cmd() for handle ublk commandtools/ | +34 | 0 replies | |
| 17/17 | selftests: ublk: add utils.htools/ tools/ | +72 | 0 replies |
Reviews trailers per patch
8 of 17 patches have a Reviewed-by or Acked-by.
| Patch | Caleb Sander Mateos |
|---|---|
| 1/17 | |
| 2/17 | |
| 3/17 | R-b |
| 4/17 | R-b |
| 5/17 | R-b |
| 6/17 | R-b |
| 7/17 | R-b |
| 8/17 | R-b |
| 9/17 | R-b |
| 10/17 | R-b |
| 11/17 | |
| 12/17 | |
| 13/17 | |
| 14/17 | |
| 15/17 | |
| 16/17 | |
| 17/17 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V3 00/17] ublk: cleanup for supporting batch IO command
Hi Jens,
The 1st 9 patches cleans ublk driver, and prepare for supporting batch IO command which needs per-io lock.
The others are selftest cleanup, and prepare for supporting arbitrary task context & ublk queue combination, which will be allowed with batch IO feature.
ublk Batch IO feature introduction:
- use per-queue multshot uring_cmd for fetching incoming io commands, and io command tag is saved to provided buffer
- use per-queue uring_cmd for completing io command result, and io tag & result are filled in uring_cmd buffer
- this way improves communication efficiency, also:
- allows each queue to be handled in any pthread contexts, and each pthread context can handle any number of queues, and driver doesn't care ublk server context any more
- help to apply blk-mq batch optimization in future
- help to support io polling in future
- github:
https://github.com/ming1/linux/commits/ublk2-cmd-batch.v3/
Almost all feedback are from Caleb, and great thanks Caleb's review!
V3:
- add patch "ublk: validate ublk server pid"
- clean "ublk: let ublk_fill_io_cmd() cover more things" by not setting io->res in ublk_fill_io_cmd()
- improve commit log
- misc patch style fix
- add reviewed-by tag
V2:
- remove one unnecessary check (Caleb Sander Mateos)
- add reviewed-by tag
- rebase on latest for-6.17/block
Ming Lei (17):
ublk: validate ublk server pid
ublk: look up ublk task via its pid in timeout handler
ublk: move fake timeout logic into __ublk_complete_rq()
ublk: let ublk_fill_io_cmd() cover more things
ublk: avoid to pass struct ublksrv_io_cmd * to
ublk_commit_and_fetch()
ublk: move auto buffer register handling into one dedicated helper
ublk: store auto buffer register data into struct ublk_io
ublk: add helper ublk_check_fetch_buf()
ublk: remove ublk_commit_and_fetch()
ublk: pass 'const struct ublk_io *' to ublk_[un]map_io()
selftests: ublk: remove tag parameter of ->tgt_io_done()
selftests: ublk: pass 'ublk_thread *' to ->queue_io() and
->tgt_io_done()
selftests: ublk: pass 'ublk_thread *' to more common helpers
selftests: ublk: remove ublk queue self-defined flags
selftests: ublk: improve flags naming
selftests: ublk: add helper ublk_handle_uring_cmd() for handle ublk
command
selftests: ublk: add utils.h
drivers/block/ublk_drv.c | 254 ++++++++++++-------- tools/testing/selftests/ublk/fault_inject.c | 15 +- tools/testing/selftests/ublk/file_backed.c | 32 +-- tools/testing/selftests/ublk/kublk.c | 140 ++++++----- tools/testing/selftests/ublk/kublk.h | 135 ++++------- tools/testing/selftests/ublk/null.c | 32 +-- tools/testing/selftests/ublk/stripe.c | 33 +-- tools/testing/selftests/ublk/utils.h | 70 ++++++ 8 files changed, 391 insertions(+), 320 deletions(-) create mode 100644 tools/testing/selftests/ublk/utils.h
Signature · 1 line
2.47.0