Skip to content

sched: Address schbench regression

Peter Zijlstra linux-m68k linux-samsung-soc lkml 1 version Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest12 patches 56 repliesApplied

Changes from the cover letter

- keep dl_server_stop(), just remove the 'normal' usage of it (juril)
- have the sched_delayed wake list IPIs do select_task_rq() (vingu)
- fixed lockdep splat (dietmar)
- added a few preperatory patches

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/12sched/psi: Optimize psi_group_change() cpu_clock() usageinclude/linux/psi_types.h kernel/sched/psi.c+68 -598 replies
2/12sched/deadline: Less agressive dl_server handlinginclude/linux/sched.h kernel/sched/deadline.c kernel/sched/fair.c+23 -1238 replies
3/12sched: Optimize ttwu() / select_task_rq()kernel/sched/core.c kernel/sched/syscalls.c+3 -52 replies
4/12sched: Use lock guard in ttwu_runnable()kernel/sched/core.c kernel/sched/sched.h+21 -202 replies
5/12sched: Add ttwu_queue controlskernel/sched/core.c kernel/sched/features.h kernel/sched/sched.h+16 -102 replies
6/12sched: Introduce ttwu_do_migrate()kernel/sched/core.c+16 -101 reply
7/12psi: Split psi_ttwu_dequeue()kernel/sched/core.c kernel/sched/stats.h+27 -152 replies
8/12sched: Re-arrange __ttwu_queue_wakelist()kernel/sched/core.c+5 -40 replies
9/12sched: Clean up ttwu commentskernel/sched/core.c+4 -40 replies
10/12sched: Use lock guard in sched_ttwu_pending()kernel/sched/core.c+7 -41 reply
11/12sched: Change ttwu_runnable() vs sched_delayedkernel/sched/core.c+4 -20 replies
12/12sched: Add ttwu_queue support for delayed tasksinclude/linux/sched.h kernel/sched/core.c kernel/sched/fair.c +2 more+110 -610 replies

Reviews trailers per patch

5 of 12 patches have a Reviewed-by or Acked-by.

PatchJohannes WeinerDietmar EggemannJuri LelliVincent GuittotMel GormanK Prateek NayakSrikanth AithalJohn Stultz
1/12A-b A-b T-b Reviewed-and-tested-by T-b T-b
2/12R-b A-b A-b T-b T-b
3/12R-b A-b
4/12R-b A-b
5/12
6/12R-b
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/12] sched: Address schbench regression

Hi!

Previous version:

https://lkml.kernel.org/r/[email protected]

Changes:
- keep dl_server_stop(), just remove the 'normal' usage of it (juril)
- have the sched_delayed wake list IPIs do select_task_rq() (vingu)
- fixed lockdep splat (dietmar)
- added a few preperatory patches

Patches apply on top of tip/master (which includes the disabling of private futex) and clm's newidle balance patch (which I'm awaiting vingu's ack on).

Performance is similar to the last version; as tested on my SPR on v6.15 base:

v6.15:
schbench-6.15.0-1.txt:average rps: 2891403.72
schbench-6.15.0-2.txt:average rps: 2889997.02
schbench-6.15.0-3.txt:average rps: 2894745.17

v6.15 + patches 1-10:
schbench-6.15.0-dirty-4.txt:average rps: 3038265.95 schbench-6.15.0-dirty-5.txt:average rps: 3037327.50 schbench-6.15.0-dirty-6.txt:average rps: 3038160.15

v6.15 + all patches:
schbench-6.15.0-dirty-deferred-1.txt:average rps: 3043404.30 schbench-6.15.0-dirty-deferred-2.txt:average rps: 3046124.17 schbench-6.15.0-dirty-deferred-3.txt:average rps: 3043627.10

Patches can also be had here:

git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core

I'm hoping we can get this merged for next cycle so we can all move on from this.