Skip to content

cma: factor out allocation logic from __cma_declare_contiguous_nid

Mike Rapoport linux-mm lkml 2 versions – Applied

Status from this message: [merged mm-stable] cma-move-memory-allocation-to-a-helper-function.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied 3/3
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

* use already declared 'ret' rather than 'err' (Oscar)
* rather than factor out only HIGHMEM allocation move all of the allocation logic to a helper (Oscar and David)
* add Acks, thanks!

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3cma: move __cma_declare_contiguous_nid() before its usagemm/cma.c+144 -1500 repliesApplied
2/3cma: split resrvation of fixed area into a helper functionmm/cma.c+27 -130 repliesApplied
3/3cma: move memory allocation to a helper functionmm/cma.c+54 -502 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchOscar SalvadorDavid Hildenbrand
1/3A-b A-b
2/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] cma: factor out allocation logic from __cma_declare_contiguous_nid

From: "Mike Rapoport (Microsoft)" <[email protected]>

Hi,

We've discussed earlier that HIGHMEM related logic is spread all over __cma_declare_contiguous_nid().

These patches decouple it into helper functions.

v2 changes:
* use already declared 'ret' rather than 'err' (Oscar)
* rather than factor out only HIGHMEM allocation move all of the allocation logic to a helper (Oscar and David)
* add Acks, thanks!

v1: https://lore.kernel.org/all/[email protected]

[1] https://lore.kernel.org/all/[email protected]

Mike Rapoport (Microsoft) (3):
cma: move __cma_declare_contiguous_nid() before its usage
cma: split resrvation of fixed area into a helper function
cma: move allocation from HIGHMEM to a helper function

 mm/cma.c | 315 +++++++++++++++++++++++++++++--------------------------
 1 file changed, 165 insertions(+), 150 deletions(-)

base-commit: 86731a2a651e58953fc949573895f2fa6d456841

Signature · 16 lines
2.47.2

*** BLURB HERE ***

Mike Rapoport (Microsoft) (3):
  cma: move __cma_declare_contiguous_nid() before its usage
  cma: split resrvation of fixed area into a helper function
  cma: move memory allocation to a helper function

 mm/cma.c | 312 +++++++++++++++++++++++++++++--------------------------
 1 file changed, 162 insertions(+), 150 deletions(-)


base-commit: 86731a2a651e58953fc949573895f2fa6d456841
-- 
2.47.2