Skip to content

Simplify the code modifying queue attributes

Bart Van Assche linux-block 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8block: Introduce QUEUE_FLAG_FROZENblock/blk-core.c block/blk-mq.c include/linux/blkdev.h+4 -00 replies
2/8block: Do not run frozen queuesblock/blk-mq.c+8 -86 replies
3/8block: Remove the quiesce/unquiesce calls on frozen queuesblock/blk-iocost.c block/blk-mq.c block/blk-sysfs.c +2 more+7 -280 replies
4/8aoe: Remove the quiesce/unquiesce calls on frozen queuesdrivers/block/aoe/aoedev.c+1 -40 replies
5/8ataflop: Remove the quiesce/unquiesce calls on frozen queuesdrivers/block/ataflop.c+0 -20 replies
6/8sunvdc: Remove the quiesce/unquiesce calls on frozen queuesdrivers/block/sunvdc.c+1 -40 replies
7/8swim3: Remove the quiesce/unquiesce calls on frozen queuesdrivers/block/swim3.c+0 -21 reply
8/8mtd_blkdevs: Remove the quiesce/unquiesce calls on frozen queuesdrivers/mtd/mtd_blkdevs.c+1 -31 reply

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchMiquel Raynal
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Simplify the code modifying queue attributes

Hi Jens,

The blk_mq_quiesce_queue() / blk_mq_unquiesce_queue() calls on frozen request queues cause confusion and also make the code more verbose than necessary. Hence this patch series that removes these quiesce / unquiesce calls. This patch series should have no performance impact on the hot path and should not modify the behavior of the block layer.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Bart Van Assche (8):
block: Introduce QUEUE_FLAG_FROZEN
block: Do not run frozen queues
block: Remove the quiesce/unquiesce calls on frozen queues
aoe: Remove the quiesce/unquiesce calls on frozen queues
ataflop: Remove the quiesce/unquiesce calls on frozen queues
sunvdc: Remove the quiesce/unquiesce calls on frozen queues
swim3: Remove the quiesce/unquiesce calls on frozen queues
mtd_blkdevs: Remove the quiesce/unquiesce calls on frozen queues

 block/blk-core.c           |  1 +
 block/blk-iocost.c         |  8 --------
 block/blk-mq.c             | 21 +++++++++------------
 block/blk-sysfs.c          | 13 +++++--------
 block/blk-throttle.c       |  2 --
 block/elevator.c           |  8 ++------
 drivers/block/aoe/aoedev.c |  5 +----
 drivers/block/ataflop.c    |  2 --
 drivers/block/sunvdc.c     |  5 +----
 drivers/block/swim3.c      |  2 --
 drivers/mtd/mtd_blkdevs.c  |  4 +---
 include/linux/blkdev.h     |  2 ++
 12 files changed, 22 insertions(+), 51 deletions(-)