RFC Relocate fh_getattr()
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | NFSD: Relocate the fh_want_write() and fh_drop_write() helpersfs/ fs/ | +37 | 0 replies | |
| 2/2 | NFSD: Move the fh_getattr() helperfs/ fs/ fs/ | +24 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/2] Relocate fh_getattr()
From: Chuck Lever <[email protected]>
Tucked away in Mike's LOCALIO branch is a patch that, among other changes, moves fh_getattr() to fs/nfsd/vfs.c. My feeling is that either:
- fh_getattr() remains as part of the NFSD FH API, thus it belongs in fs/nfsd/nfsfh.c; or
- if it is to be relocated to fs/nfsd/vfs.c, then it should adopt the naming convention used for the public functions in that source file.
This patch series tries on the first approach, for size.
It's a nit, I know.
Chuck Lever (2):
NFSD: Relocate the fh_want_write() and fh_drop_write() helpers
NFSD: Move the fh_getattr() helper
fs/nfsd/nfsfh.c | 23 +++++++++++++++++++++++ fs/nfsd/nfsfh.h | 38 ++++++++++++++++++++++++++++++++++++++ fs/nfsd/vfs.h | 33 --------------------------------- 3 files changed, 61 insertions(+), 33 deletions(-)
Signature · 1 line
2.50.0