Skip to content

x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present

Adrian Hunter kvm lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 3 repliesIn review
  2. v63 patches 4 repliesSuperseded
  3. v53 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches12 repliesSuperseded
v32 patches3 repliesSuperseded
v22 patches18 repliesSuperseded
v12 patches4 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86/tdx: Eliminate duplicate code in tdx_clear_page()arch/x86/include/asm/tdx.h arch/x86/kvm/vmx/tdx.c arch/x86/virt/vmx/tdx/tdx.c+13 -241 reply
2/3x86/tdx: Tidy reset_pamt functionsarch/x86/virt/vmx/tdx/tdx.c+4 -121 reply
3/3x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is presentarch/x86/virt/vmx/tdx/tdx.c+7 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKirill A. ShutemovBinbin WuXiaoyao LiKai HuangSean ChristophersonRick EdgecombeVishal Annapurve
1/3R-b R-b R-b A-b A-b R-b A-b
2/3R-b A-b R-b A-b
3/3R-b R-b R-b A-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v7 thread

Cover letter [PATCH V7 0/3] x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present

Hi

Here are 3 small self-explanatory patches related to clearing TDX private pages.

Patch 1 and 2 are minor tidy-ups.

In patch 3, by skipping the clearing step, shutdown time can improve by up to 40%.

Changes in V7:

Add Rev'd-by, Ack'd-by tags

Changes in V6:

x86/tdx: Eliminate duplicate code in tdx_clear_page()
Add Sean's Ack

x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present
Add Xiaoyao's Rev'd-by

Changes in V5:

x86/tdx: Tidy reset_pamt functions
New patch

Changes in V4:

x86/tdx: Eliminate duplicate code in tdx_clear_page()
Add and use tdx_quirk_reset_page() for KVM (Sean)

x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present
Add TDX Module Base spec. version (Rick)
Add Rick's Rev'd-by

Changes in V3:

x86/tdx: Eliminate duplicate code in tdx_clear_page()
Explain "quirk" rename in commit message (Rick) Explain mb() change in commit message (Rick) Add Rev'd-by, Ack'd-by tags

x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present
Remove "flush cache" comments (Rick)
Update function comment to better relate to "quirk" naming (Rick) Add "via MOVDIR64B" to comment (Xiaoyao)
Add Rev'd-by, Ack'd-by tags

Changes in V2 (as requested by Dave):

x86/tdx: Eliminate duplicate code in tdx_clear_page()
Rename reset_tdx_pages() to tdx_quirk_reset_paddr() Call tdx_quirk_reset_paddr() directly

x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present
Improve the comment

Adrian Hunter (3):
x86/tdx: Eliminate duplicate code in tdx_clear_page()
x86/tdx: Tidy reset_pamt functions
x86/tdx: Skip clearing reclaimed pages unless X86_BUG_TDX_PW_MCE is present

 arch/x86/include/asm/tdx.h  |  2 ++
 arch/x86/kvm/vmx/tdx.c      | 25 +++----------------------
 arch/x86/virt/vmx/tdx/tdx.c | 36 +++++++++++++++++++-----------------
 3 files changed, 24 insertions(+), 39 deletions(-)

Regards
Adrian