drm/imagination: Fixes for flexible structures
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected] change-id 20250704-flex-array-check-ac9c3b6f130eVersions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | drm/imagination: Add and use FLEX_ARRAY_CHECK()drivers/ | +18 | 1 reply | |
| 2/2 | drm/imagination: Use struct_size_t()drivers/ | +5 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Alessio Belle |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] drm/imagination: Fixes for flexible structures
These fixes were made as part of investigating the Sparse issue reported in [1]; specifically that the sizeof() check for the flexible structure struct rogue_fwif_frag_ctx_state was failing under Sparse.
This is actually a fairly pointless check, and the discrepancy is related to the implicit padding at the end of the structure that is never used due to the flexible array member. A far more useful check is to assert that the final member is indeed a flexible array as expected, and that one element of said array is of the size that we expect.
While fixing that, I stumbled on the useful struct_size_t() macro and put it to good use wherever the size of the structure in question is computed.
[1]: https://lore.kernel.org/r/[email protected]
---
Matt Coster (2):
drm/imagination: Add and use FLEX_ARRAY_CHECK() drm/imagination: Use struct_size_t()
drivers/gpu/drm/imagination/pvr_queue.c | 11 +++++------ drivers/gpu/drm/imagination/pvr_rogue_fwif_check.h | 19 ++++++++++++++++++- 2 files changed, 23 insertions(+), 7 deletions(-)
---
base-commit: fe88fb3421161f3abd974ee2ecbe2d9195f98812
change-id: 20250704-flex-array-check-ac9c3b6f130e