Skip to content

drm/imagination: Fixes for flexible structures

Matt Coster dri-devel lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20250704-flex-array-check-ac9c3b6f130e

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2drm/imagination: Add and use FLEX_ARRAY_CHECK()drivers/gpu/drm/imagination/pvr_rogue_fwif_check.h+18 -11 reply
2/2drm/imagination: Use struct_size_t()drivers/gpu/drm/imagination/pvr_queue.c+5 -61 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAlessio Belle
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] drm/imagination: Fixes for flexible structures

These fixes were made as part of investigating the Sparse issue reported in [1]; specifically that the sizeof() check for the flexible structure struct rogue_fwif_frag_ctx_state was failing under Sparse.

This is actually a fairly pointless check, and the discrepancy is related to the implicit padding at the end of the structure that is never used due to the flexible array member. A far more useful check is to assert that the final member is indeed a flexible array as expected, and that one element of said array is of the size that we expect.

While fixing that, I stumbled on the useful struct_size_t() macro and put it to good use wherever the size of the structure in question is computed.

[1]: https://lore.kernel.org/r/[email protected]

---
Matt Coster (2):
drm/imagination: Add and use FLEX_ARRAY_CHECK() drm/imagination: Use struct_size_t()

 drivers/gpu/drm/imagination/pvr_queue.c            | 11 +++++------
 drivers/gpu/drm/imagination/pvr_rogue_fwif_check.h | 19 ++++++++++++++++++-
 2 files changed, 23 insertions(+), 7 deletions(-)

---
base-commit: fe88fb3421161f3abd974ee2ecbe2d9195f98812
change-id: 20250704-flex-array-check-ac9c3b6f130e