Skip to content

NFSD: Fix last write offset handling in layoutcommit

Sergey Bashirov linux-nfs lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- The first cleanup patch is unchanged
- Reworked main patch to guard entire new_size check, improved description
- Added cleanup patch to decode lc_newoffset as bool

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3NFSD: Minor cleanup in layoutcommit processingfs/nfsd/nfs4proc.c+3 -90 replies
2/3NFSD: Fix last write offset handling in layoutcommitfs/nfsd/blocklayout.c fs/nfsd/nfs4proc.c+17 -181 reply
3/3NFSD: Minor cleanup in layoutcommit decodingfs/nfsd/nfs4xdr.c+1 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] NFSD: Fix last write offset handling in layoutcommit

These patches correct the behavior of the pNFS server when the client sends a layoutcommit without a new file size and with zero number of block/scsi extents.

Tested manually for the pNFS block layout setup.

---
Changes in v2:
- The first cleanup patch is unchanged
- Reworked main patch to guard entire new_size check, improved description
- Added cleanup patch to decode lc_newoffset as bool

Sergey Bashirov (3):
NFSD: Minor cleanup in layoutcommit processing
NFSD: Fix last write offset handling in layoutcommit
NFSD: Minor cleanup in layoutcommit decoding

 fs/nfsd/blocklayout.c |  5 ++---
 fs/nfsd/nfs4proc.c    | 34 ++++++++++++++--------------------
 fs/nfsd/nfs4xdr.c     |  2 +-
 3 files changed, 17 insertions(+), 24 deletions(-)
Signature · 1 line
2.43.0