improve cmdline file handling in testpmd
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 7 repliesIn review
- v33 patches 1 replySuperseded
- v23 patches 0 repliesSuperseded
Changes in v4 from the cover letter
* remove ifdefs in testpmd code, by providing common rte_basename fn
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | eal: add basename function for common path manipulationapp/ lib/ lib/ +3 more | +235 | 4 replies | |
| 2/4 | app/testpmd: explicitly set command echoing on file loadapp/ app/ app/ +1 more | +49 | 1 reply | |
| 3/4 | app/testpmd: allow multiple commandline file parametersapp/ app/ app/ +2 more | +36 | 1 reply | |
| 4/4 | app/testpmd: improve output when processing cmdline filesapp/ doc/ | +17 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Andre Muezerie |
|---|---|
| 1/4 | A-b |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/4] improve cmdline file handling in testpmd
Some small improvements to cmdline file handling testpmd, inspired by the desire to have support for multiple cmdline files passed on the commandline of a testpmd run.
The implementation is somewhat complicated by the setting for echo/noecho of the commands, because the current implementation uses a global flag for that - shared between cmdline parameters and interactive CLI commands.
The final complication/addition, is the need for a common basename function across our supported OS's. This is provided by the rte_basename function in patch 1.
V4:
* remove ifdefs in testpmd code, by providing common rte_basename fn
V3:
* Fix windows support, no libgen or basename, no asprintf...
V2:
* remove global echo flag, and now support echo/noecho per file loaded
* when echoing, output the file being processed, to clarify things when loading multiple files.
Bruce Richardson (4):
eal: add basename function for common path manipulation app/testpmd: explicitly set command echoing on file load app/testpmd: allow multiple commandline file parameters app/testpmd: improve output when processing cmdline files
app/test-pmd/cmdline.c | 69 ++++++++++-- app/test-pmd/parameters.c | 17 +-- app/test-pmd/testpmd.c | 13 ++- app/test-pmd/testpmd.h | 15 ++- app/test/test_string_fns.c | 111 ++++++++++++++++++++ doc/guides/testpmd_app_ug/run_app.rst | 3 +- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-- lib/eal/include/rte_string_fns.h | 32 ++++++ lib/eal/unix/meson.build | 1 + lib/eal/unix/rte_basename.c | 37 +++++++ lib/eal/windows/meson.build | 1 + lib/eal/windows/rte_basename.c | 53 ++++++++++ 12 files changed, 336 insertions(+), 28 deletions(-) create mode 100644 lib/eal/unix/rte_basename.c create mode 100644 lib/eal/windows/rte_basename.c
Signature · 1 line
2.48.1