Skip to content

btrfs: be less verbose on automatic bg reclaim

Johannes Thumshirn linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: remove redundant auto reclaim log messagefs/btrfs/block-group.c+0 -60 replies
2/2btrfs: don't print relocation messages from auto reclaimfs/btrfs/block-group.c fs/btrfs/relocation.c fs/btrfs/relocation.h +2 more+21 -130 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Burkov
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: be less verbose on automatic bg reclaim

From: Johannes Thumshirn <[email protected]>

BTRFS filesystems with active automatic block-group reclaim (this especially hits zoned file systems where automatic block-group reclaim is used for garbage collection) do a lot of log spamming, because every relocated block group is accompanied by three prints at info level.

The first patch removes the info message that is only present with automatic block group reclaim, we have a tracepoint right next to it so there's no need for the message at all.

The second patch introduces a verbose parameter for btrfs_relocate_chunk() and btrfs_relocate_block_group() to control if we want to add printks or not. Automatic reclaim calls into btrfs_relocate_chunk() setting verbose to false while the user-space triggered balance code path sets verbose to true retaining the old behaviour.

Johannes Thumshirn (2):
btrfs: remove redundant auto reclaim log message
btrfs: don't print relocation messages from auto reclaim

 fs/btrfs/block-group.c |  8 +-------
 fs/btrfs/relocation.c  | 12 ++++++++----
 fs/btrfs/relocation.h  |  3 ++-
 fs/btrfs/volumes.c     | 14 ++++++++------
 fs/btrfs/volumes.h     |  3 ++-
 5 files changed, 21 insertions(+), 19 deletions(-)
Signature · 1 line
2.50.0