Skip to content

media: uvcvideo: Use a count variable for meta_formats

Hans de Goede linux-media 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 0 repliesNew

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

PatchRicardo Ribalda
SeriesR-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] media: uvcvideo: Use a count variable for meta_formats

Hi,

I still was not entirely happy with how the meta_formats handling code looked, especially not with uvc_meta_v4l2_enum_formats().

So here is a small patch / attempt to clean it up a bit.

Ricardo, assuming you're ok with the suggested changes can you give this a test please ?

My main UVC test cam only supports standard UVC metadata which is not helpful for testing (1), I did give this patch a spin with that camera but that does not say much.

Regards,

Hans

1) It is a microsoft HD camera (but quite old) so I wonder if maybe it does have the metadata but not the extended control for enabling it. How would I test this ?

Hans de Goede (1):
media: uvcvideo: Use a count variable for meta_formats instead of 0
terminating

 drivers/media/usb/uvc/uvc_metadata.c | 21 +++++++++------------
 drivers/media/usb/uvc/uvcvideo.h     |  4 ++--
 2 files changed, 11 insertions(+), 14 deletions(-)
Signature · 1 line
2.49.0