Skip to content

RFC NFSD: support DIO

Mike Snitzer linux-block linux-fsdevel linux-mm linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 RFC Latest8 patches 24 repliesIn review

Changes in v2 from the cover letter

- Rebased ontop of Chuck's proposed fh_getattr movement (Chuck, I like it so went with it).
- NFSD's expanding of misaligned READ DIO to be DIO-aligned that resulted in 'start_extra' blocks being read into associated pages caused incorrect data to be returned from NFSD. This was caught using the 'dt' utility. See patch 8 for more details.
- This v2 patchset has been tested pretty extensively now.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8NFSD: Relocate the fh_want_write() and fh_drop_write() helpersfs/nfsd/nfsfh.h fs/nfsd/vfs.h+37 -201 reply
2/8NFSD: Move the fh_getattr() helperfs/nfsd/nfsfh.c fs/nfsd/nfsfh.h fs/nfsd/vfs.h+24 -131 reply
3/8NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN supportfs/nfsd/filecache.c fs/nfsd/filecache.h fs/nfsd/nfsfh.c+40 -02 replies
4/8lib/iov_iter: remove piecewise bvec length checking in iov_iter_aligned_bveclib/iov_iter.c+3 -212 replies
5/8NFSD: pass nfsd_file to nfsd_iter_read()fs/nfsd/nfs4xdr.c fs/nfsd/vfs.c fs/nfsd/vfs.h+9 -80 replies
6/8NFSD: add io_cache_read controls to debugfs interfacefs/nfsd/debugfs.c fs/nfsd/nfsd.h fs/nfsd/vfs.c+76 -06 replies
7/8NFSD: add io_cache_write controls to debugfs interfacefs/nfsd/debugfs.c fs/nfsd/nfsd.h fs/nfsd/vfs.c+57 -00 replies
8/8NFSD: issue READs using O_DIRECT even if IO is misalignedfs/nfsd/trace.h fs/nfsd/vfs.c include/linux/sunrpc/svc.h+161 -222 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchJeff Layton
1/8R-b
2/8R-b
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH v2 0/8] NFSD: support DIO

Hi,

The v1 thread had quite a bit of discussion, and here are some
highlights worth reading to provide background:
jeff's summary: https://lore.kernel.org/linux-nfs/[email protected]/
performance: https://lore.kernel.org/linux-nfs/[email protected]/

Changes since v1:
- Rebased ontop of Chuck's proposed fh_getattr movement (Chuck, I like it so went with it).
- NFSD's expanding of misaligned READ DIO to be DIO-aligned that resulted in 'start_extra' blocks being read into associated pages caused incorrect data to be returned from NFSD. This was caught using the 'dt' utility. See patch 8 for more details.
- This v2 patchset has been tested pretty extensively now.

I haven't time to explore Christoph's pagecache idea like I hoped:
https://lore.kernel.org/linux-nfs/[email protected]/

Any help with hardening against page cache invalidation problems due to mixing O_DIRECT and buffered IO appreciated. ;)

Thanks,
Mike

ps. I have a LOCALIO patchset that I'll be posting next that benefits from this NFSD patchset.

Chuck Lever (2):
NFSD: Relocate the fh_want_write() and fh_drop_write() helpers
NFSD: Move the fh_getattr() helper

Mike Snitzer (6):
NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support lib/iov_iter: remove piecewise bvec length checking in iov_iter_aligned_bvec
NFSD: pass nfsd_file to nfsd_iter_read()
NFSD: add io_cache_read controls to debugfs interface
NFSD: add io_cache_write controls to debugfs interface
NFSD: issue READs using O_DIRECT even if IO is misaligned

 fs/nfsd/debugfs.c          |  94 ++++++++++++++++++++++
 fs/nfsd/filecache.c        |  32 ++++++++
 fs/nfsd/filecache.h        |   4 +
 fs/nfsd/nfs4xdr.c          |   8 +-
 fs/nfsd/nfsd.h             |   9 +++
 fs/nfsd/nfsfh.c            |  27 +++++++
 fs/nfsd/nfsfh.h            |  38 +++++++++
 fs/nfsd/trace.h            |  37 +++++++++
 fs/nfsd/vfs.c              | 154 ++++++++++++++++++++++++++++++++++---
 fs/nfsd/vfs.h              |  35 +--------
 include/linux/sunrpc/svc.h |   5 +-
 lib/iov_iter.c             |   5 +-
 12 files changed, 395 insertions(+), 53 deletions(-)
Signature · 1 line
2.44.0