Skip to content

drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

Javier Martinez Canillas dri-devel linux-devicetree lkml 3 versions – Applied

Status from this message: Pushed to drm-misc (drm-misc-next). Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyApplied
  2. v25 patches 6 repliesSuperseded
  3. v13 patches 11 repliesSuperseded

Changes in v3 from the cover letter

- Fix reset typo in commit message (Marcus Folkesson).
- Explicitly set ST7571_SET_REVERSE(0) instead of relying on defaults.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5drm/sitronix/st7571-i2c: Fix encoder callbacks function namesdrivers/gpu/drm/sitronix/st7571-i2c.c+6 -60 replies
2/5drm/sitronix/st7571-i2c: Log probe deferral cause for GPIO get failuredrivers/gpu/drm/sitronix/st7571-i2c.c+3 -10 replies
3/5drm/sitronix/st7571-i2c: Add an indirection level to parse DTdrivers/gpu/drm/sitronix/st7571-i2c.c+3 -10 replies
4/5dt-bindings: display: Add Sitronix ST7567 LCD ControllerDocumentation/devicetree/bindings/display/sitronix,st7567.yaml MAINTAINERS+64 -00 replies
5/5drm/sitronix/st7571-i2c: Add support for the ST7567 Controllerdrivers/gpu/drm/sitronix/st7571-i2c.c+75 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMarcus FolkessonRob Herring (Arm)Thomas Zimmermann
1/5R-b
2/5R-b
3/5R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

This patch-series adds support for the Sitronix ST7567 Controller, which is a monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces.

The st7571-i2c driver only has support for I2C so displays using other transport interfaces are currently not supported.

The DRM_FORMAT_R1 pixel format and data commands are the same than what is used by the ST7571 controller, so only is needed a different callback that implements the expected initialization sequence for the ST7567 chip and a different callback to parse the sub-set of DT properties needed by the ST7567.

Patches #1 and #2 are some trivial cleanups for the driver.

Patch #3 is a preparatory change that adds the level of indirection for the DT parsing logic.

Patch #4 adds a Device Tree binding schema for the ST7567 Controller.

Patch #5 finally extends the st7571-i2c driver to also support the ST7567 device.

Changes in v3:
- Fix reset typo in commit message (Marcus Folkesson).
- Explicitly set ST7571_SET_REVERSE(0) instead of relying on defaults.

Changes in v2:
- Use a different parse DT function (Thomas Zimmermann).

Javier Martinez Canillas (5):
drm/sitronix/st7571-i2c: Fix encoder callbacks function names drm/sitronix/st7571-i2c: Log probe deferral cause for GPIO get failure drm/sitronix/st7571-i2c: Add an indirection level to parse DT
dt-bindings: display: Add Sitronix ST7567 LCD Controller drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

 .../bindings/display/sitronix,st7567.yaml     | 63 ++++++++++++
 MAINTAINERS                                   |  1 +
 drivers/gpu/drm/sitronix/st7571-i2c.c         | 95 +++++++++++++++++--
 3 files changed, 151 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7567.yaml
Signature · 4 lines
2.49.0

base-commit: d5ca45b508916144d1e8be1102bedab405c1f6fb
branch: drm-st7567-v3