Skip to content

IIO: More application of IWYU principles to includes.

Jonathan Cameron linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7iio: pressure: bmp280: Apply iwyu principles to includes.drivers/iio/pressure/bmp280-core.c drivers/iio/pressure/bmp280-i2c.c drivers/iio/pressure/bmp280-regmap.c +1 more+29 -41 reply
2/7iio: pressure: zpa2326: Apply iwyu principles to includesdrivers/iio/pressure/zpa2326.c drivers/iio/pressure/zpa2326.h drivers/iio/pressure/zpa2326_i2c.c +1 more+29 -70 replies
3/7iio: pressure: mpl115: Apply iwyu principles to includesdrivers/iio/pressure/mpl115.c drivers/iio/pressure/mpl115.h drivers/iio/pressure/mpl115_i2c.c +1 more+23 -40 replies
4/7iio: pressure: ms5611: Apply iwyu principles to includesdrivers/iio/pressure/ms5611_core.c drivers/iio/pressure/ms5611_i2c.c drivers/iio/pressure/ms5611_spi.c+23 -60 replies
5/7iio: pressure: hsc030pa: Apply IWYU principles to includes.drivers/iio/pressure/hsc030pa.c drivers/iio/pressure/hsc030pa.h drivers/iio/pressure/hsc030pa_i2c.c +1 more+8 -180 replies
6/7iio: pressure: mprls0025pa: Apply IWYU principles to includes.drivers/iio/pressure/mprls0025pa.c drivers/iio/pressure/mprls0025pa.h drivers/iio/pressure/mprls0025pa_i2c.c+9 -100 replies
7/7iio: st_sensors: Apply IWYU principles to includesdrivers/iio/accel/st_accel_buffer.c drivers/iio/accel/st_accel_core.c drivers/iio/accel/st_accel_i2c.c +24 more+128 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] IIO: More application of IWYU principles to includes.

From: Jonathan Cameron <[email protected]>

I decided to look at a slightly larger set to continue trying to come up with consistent rules (for IIO anyway) on what we want to include direclty and what assumptions we can make about a header always including another.

As the series goes on reduce the amount of info on particular choices made just because the commit descriptions were getting very long.

A few open questions.
- linux/stddef.h - do we want to included this directly?
- linux/types.h - do we want to include this directly?
- linux/dev_printk.h - include even if device.h is needed for other reasons or rely on that as a grouping header if present and only use dev_printk where we don't need device.h.

I'll share a refreshed IWYU config once we come to firmer conclusions on the various choices. I haven't yet figured out now to not include anything at all for things like CONFIG*

Jonathan Cameron (7):
iio: pressure: bmp280: Apply iwyu principles to includes.
iio: pressure: zpa2326: Apply iwyu principles to includes
iio: pressure: mpl115: Apply iwyu principles to includes
iio: pressure: ms5611: Apply iwyu principles to includes
iio: pressure: hsc030pa: Apply IWYU principles to includes.
iio: pressure: mprls0025pa: Apply IWYU principles to includes.
iio: st_sensors: Apply IWYU principles to includes

 drivers/iio/accel/st_accel_buffer.c           |  6 ++++--
 drivers/iio/accel/st_accel_core.c             | 12 ++++++++---
 drivers/iio/accel/st_accel_i2c.c              |  5 ++++-
 drivers/iio/accel/st_accel_spi.c              |  3 ++-
 .../iio/common/st_sensors/st_sensors_buffer.c | 15 +++++++++-----
 .../iio/common/st_sensors/st_sensors_core.c   | 19 ++++++++++++++----
 .../iio/common/st_sensors/st_sensors_core.h   |  2 ++
 .../iio/common/st_sensors/st_sensors_i2c.c    |  8 ++++++--
 .../iio/common/st_sensors/st_sensors_spi.c    | 11 ++++++++--
 .../common/st_sensors/st_sensors_trigger.c    | 13 +++++++++---
 drivers/iio/gyro/st_gyro_buffer.c             |  6 ++++--
 drivers/iio/gyro/st_gyro_core.c               | 11 +++++++---
 drivers/iio/gyro/st_gyro_i2c.c                |  3 ++-
 drivers/iio/gyro/st_gyro_spi.c                |  3 ++-
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c  |  5 ++++-
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c   |  5 ++---
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c   |  5 ++---
 drivers/iio/magnetometer/st_magn_buffer.c     |  5 +++--
 drivers/iio/magnetometer/st_magn_core.c       | 11 +++++++---
 drivers/iio/magnetometer/st_magn_i2c.c        |  3 ++-
 drivers/iio/magnetometer/st_magn_spi.c        |  3 ++-
 drivers/iio/pressure/bmp280-core.c            | 17 ++++++++++++++--
 drivers/iio/pressure/bmp280-i2c.c             |  4 ++++
 drivers/iio/pressure/bmp280-regmap.c          |  6 ++++--
 drivers/iio/pressure/bmp280-spi.c             |  6 ++++++
 drivers/iio/pressure/hsc030pa.c               | 12 +++++------
 drivers/iio/pressure/hsc030pa.h               |  5 ++---
 drivers/iio/pressure/hsc030pa_i2c.c           |  4 ----
 drivers/iio/pressure/hsc030pa_spi.c           |  5 -----
 drivers/iio/pressure/mpl115.c                 | 13 +++++++++---
 drivers/iio/pressure/mpl115.h                 |  1 +
 drivers/iio/pressure/mpl115_i2c.c             |  8 +++++++-
 drivers/iio/pressure/mpl115_spi.c             |  5 +++++
 drivers/iio/pressure/mprls0025pa.c            |  9 +++++++--
 drivers/iio/pressure/mprls0025pa.h            |  9 ++-------
 drivers/iio/pressure/mprls0025pa_i2c.c        |  1 -
 drivers/iio/pressure/ms5611_core.c            | 15 +++++++++++---
 drivers/iio/pressure/ms5611_i2c.c             |  5 ++++-
 drivers/iio/pressure/ms5611_spi.c             |  9 +++++++--
 drivers/iio/pressure/st_pressure_buffer.c     |  6 ++++--
 drivers/iio/pressure/st_pressure_core.c       |  9 ++++++---
 drivers/iio/pressure/st_pressure_i2c.c        |  3 ++-
 drivers/iio/pressure/st_pressure_spi.c        |  3 ++-
 drivers/iio/pressure/zpa2326.c                | 20 +++++++++++++++----
 drivers/iio/pressure/zpa2326.h                |  3 +++
 drivers/iio/pressure/zpa2326_i2c.c            |  7 +++++--
 drivers/iio/pressure/zpa2326_spi.c            |  6 +++++-
 include/linux/iio/common/st_sensors_i2c.h     |  5 ++---
 include/linux/iio/common/st_sensors_spi.h     |  5 ++---
 49 files changed, 249 insertions(+), 106 deletions(-)
Signature · 1 line
2.50.0