dma::Device trait and DMA mask
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 10 repliesIn review
- v15 patches 12 repliesSuperseded
Changes in v2 from the cover letter
- replace dma_bit_mask() with a new type DmaMask
- mention that DmaMask is the Rust equivalent of the C macro DMA_BIT_MASK()
- make DmaMask::new() fallible
- inline DmaMask methods
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rust: dma: implement `dma::Device` traitrust/ | +12 | 0 replies | |
| 2/5 | rust: dma: add DMA addressing capabilitiesrust/ rust/ | +113 | 7 replies | |
| 3/5 | rust: pci: implement the `dma::Device` traitrust/ | +2 | 0 replies | |
| 4/5 | rust: platform: implement the `dma::Device` traitrust/ | +2 | 0 replies | |
| 5/5 | rust: samples: dma: set DMA masksamples/ | +13 | 0 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Abdiel Janulgue | Greg Kroah-Hartman | Daniel Almeida |
|---|---|---|---|
| Series | R-b | R-b | |
| 1/5 | R-b | ||
| 2/5 | R-b | ||
| 3/5 | |||
| 4/5 | |||
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/5] dma::Device trait and DMA mask
This patch series adds the dma::Device trait to be implemented by bus devices on DMA capable busses.
The dma::Device trait implements methods to set the DMA mask for for such devices.
The first two bus devices implementing the trait are PCI and platform.
Unfortunately, the DMA mask setters have to be unsafe for now, since, with reasonable effort, we can't prevent drivers from data races writing and reading the DMA mask fields concurrently (see also [1]).
Changes in v2:
- replace dma_bit_mask() with a new type DmaMask
- mention that DmaMask is the Rust equivalent of the C macro DMA_BIT_MASK()
- make DmaMask::new() fallible
- inline DmaMask methods
Danilo Krummrich (5):
rust: dma: implement dma::Device trait
rust: dma: add DMA addressing capabilities
rust: pci: implement the dma::Device trait
rust: platform: implement the dma::Device trait
rust: samples: dma: set DMA mask
rust/helpers/dma.c | 5 ++ rust/kernel/dma.rs | 125 ++++++++++++++++++++++++++++++++++++--- rust/kernel/pci.rs | 2 + rust/kernel/platform.rs | 2 + samples/rust/rust_dma.rs | 14 ++++- 5 files changed, 140 insertions(+), 8 deletions(-)
base-commit: d49ac7744f578bcc8708a845cce24d3b91f86260
Signature · 1 line
2.50.0