Skip to content

ethtool: rss: support RSS_SET via Netlink

Jakub Kicinski netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 3 repliesApplied 11/11
  2. v211 patches 7 repliesSuperseded
  3. v111 patches 21 repliesSuperseded

Changes in v3 from the cover letter

- decode xfrm-input as flags not enum
- check driver supports get_rxnfc op
v2: https://lore.kernel.org/[email protected]
- commit message changes
- make sure driver implements the set_rxfh op
- add comment about early return when lacking get
- set IFF_RXFH_CONFIGURED even if user sets the table to identical to default
- use ethnl_update_binary()
- make sure we free indir if key parsing fails
- tests: fix existing rxfh_input_xfrm test for string decode
- tests: make defer() cleanup more intelligent WRT ordering
v1: https://lore.kernel.org/[email protected]

Patches in v3 All 11 applied

#Subject and filesSizeRepliesApplied
1/11ethtool: rss: initial RSS_SET (indirection table handling)Documentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink_generated.h +3 more+242 -11 replyApplied
2/11selftests: drv-net: rss_api: factor out checking min queue counttools/testing/selftests/drivers/net/hw/rss_api.py+9 -80 repliesApplied
3/11tools: ynl: support packing binary arrays of scalarstools/net/ynl/pyynl/lib/ynl.py+6 -10 repliesApplied
4/11selftests: drv-net: rss_api: test setting indirection table via Netlinktools/testing/selftests/drivers/net/hw/rss_api.py+93 -30 repliesApplied
5/11ethtool: rss: support setting hfunc via NetlinkDocumentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst net/ethtool/rss.c+13 -10 repliesApplied
6/11ethtool: rss: support setting hkey via NetlinkDocumentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst net/ethtool/rss.c+42 -10 repliesApplied
7/11selftests: drv-net: rss_api: test setting hashing key via Netlinktools/testing/selftests/drivers/net/hw/rss_api.py+33 -00 repliesApplied
8/11netlink: specs: define input-xfrm enum in the specDocumentation/netlink/specs/ethtool.yaml tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py+24 -31 replyApplied
9/11ethtool: rss: support setting input-xfrm via NetlinkDocumentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst net/ethtool/common.c +3 more+71 -80 repliesApplied
10/11ethtool: rss: support setting flow hashing fieldsDocumentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst net/ethtool/netlink.h +1 more+107 -101 replyApplied
11/11selftests: drv-net: rss_api: test input-xfrm and hash fieldstools/testing/selftests/drivers/net/hw/rss_api.py+143 -00 repliesApplied

Reviews trailers per patch

7 of 11 patches have a Reviewed-by or Acked-by.

PatchEdward CreeGal Pressman
1/11R-b
2/11
3/11
4/11R-b
5/11R-b
6/11R-b
7/11
8/11R-b
9/11R-b
10/11R-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 00/11] ethtool: rss: support RSS_SET via Netlink

Support configuring RSS settings via Netlink.
Creating and removing contexts remains for the following series.

v3:
- decode xfrm-input as flags not enum
- check driver supports get_rxnfc op
v2: https://lore.kernel.org/[email protected]
- commit message changes
- make sure driver implements the set_rxfh op
- add comment about early return when lacking get
- set IFF_RXFH_CONFIGURED even if user sets the table to identical to default
- use ethnl_update_binary()
- make sure we free indir if key parsing fails
- tests: fix existing rxfh_input_xfrm test for string decode
- tests: make defer() cleanup more intelligent WRT ordering
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (11):
ethtool: rss: initial RSS_SET (indirection table handling)
selftests: drv-net: rss_api: factor out checking min queue count
tools: ynl: support packing binary arrays of scalars
selftests: drv-net: rss_api: test setting indirection table via
Netlink
ethtool: rss: support setting hfunc via Netlink
ethtool: rss: support setting hkey via Netlink
selftests: drv-net: rss_api: test setting hashing key via Netlink
netlink: specs: define input-xfrm enum in the spec
ethtool: rss: support setting input-xfrm via Netlink
ethtool: rss: support setting flow hashing fields
selftests: drv-net: rss_api: test input-xfrm and hash fields

 Documentation/netlink/specs/ethtool.yaml      |  37 ++
 Documentation/networking/ethtool-netlink.rst  |  29 +-
 .../uapi/linux/ethtool_netlink_generated.h    |   1 +
 net/ethtool/common.h                          |   1 +
 net/ethtool/netlink.h                         |   1 +
 net/ethtool/common.c                          |  15 +
 net/ethtool/ioctl.c                           |   4 +-
 net/ethtool/netlink.c                         |   8 +
 net/ethtool/rss.c                             | 389 ++++++++++++++++++
 tools/net/ynl/pyynl/lib/ynl.py                |   7 +-
 .../selftests/drivers/net/hw/rss_api.py       | 289 ++++++++++++-
 .../drivers/net/hw/rss_input_xfrm.py          |   6 +-
 12 files changed, 767 insertions(+), 20 deletions(-)
Signature · 1 line
2.50.1