netfs: Fix use of fscache with ceph
Status from this message: Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | netfs: Fix copy-to-cache so that it performs collection with ceph+fscachefs/ | +1 | 1 reply | |
| 2/2 | netfs: Fix race between cache write completion and ALL_QUEUED being setfs/ include/ | +34 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paulo Alcantara (Red Hat) |
|---|---|
| Series | R-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] netfs: Fix use of fscache with ceph
Hi Christian,
Here are a couple of patches that fix the use of fscaching with ceph:
(1) Fix the read collector to mark the write request that it creates to copy data to the cache with NETFS_RREQ_OFFLOAD_COLLECTION so that it will run the write collector on a workqueue as it's meant to run in the background and the app isn't going to wait for it.
(2) Fix the read collector to wake up the copy-to-cache write request after it sets NETFS_RREQ_ALL_QUEUED if the write request doesn't have any subrequests left on it. ALL_QUEUED indicates that there won't be any more subreqs coming and the collector should clean up - except that an event is needed to trigger that, but it only gets events from subreq termination and so the last event can beat us to setting ALL_QUEUED.
The patches can also be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
Thanks,
David
David Howells (2):
netfs: Fix copy-to-cache so that it performs collection with
ceph+fscache
netfs: Fix race between cache write completion and ALL_QUEUED being
set
fs/netfs/read_pgpriv2.c | 5 +++++ include/trace/events/netfs.h | 30 ++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+)