Skip to content

RFC arm_mpam: Add basic mpam driver

James Morse linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest36 patches 80 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/36cacheinfo: Set cache 'id' based on DT datadrivers/base/cacheinfo.c+45 -00 replies
2/36cacheinfo: Add arch hook to compress CPU h/w id into 32 bits for cache-iddrivers/base/cacheinfo.c+5 -00 replies
3/36arm64: cacheinfo: Provide helper to compress MPIDR value into u32arch/arm64/include/asm/cache.h+17 -00 replies
4/36cacheinfo: Expose the code to generate a cache-id from a device_nodedrivers/base/cacheinfo.c include/linux/cacheinfo.h+13 -53 replies
5/36ACPI / PPTT: Add a helper to fill a cpumask from a processor containerdrivers/acpi/pptt.c include/linux/acpi.h+99 -06 replies
6/36ACPI / PPTT: Stop acpi_count_levels() expecting callers to clear levelsdrivers/acpi/pptt.c+3 -12 replies
7/36ACPI / PPTT: Find cache level by cache-iddrivers/acpi/pptt.c include/linux/acpi.h+78 -04 replies
8/36ACPI / PPTT: Add a helper to fill a cpumask from a cache_iddrivers/acpi/pptt.c include/linux/acpi.h+76 -02 replies
9/36arm64: kconfig: Add Kconfig entry for MPAMarch/arm64/Kconfig+17 -01 reply
10/36ACPI / MPAM: Parse the MPAM tablearch/arm64/Kconfig drivers/acpi/arm64/Kconfig drivers/acpi/arm64/Makefile +3 more+417 -19 replies
11/36dt-bindings: arm: Add MPAM MSC bindingDocumentation/devicetree/bindings/arm/arm,mpam-msc.yaml+227 -02 replies
12/36platform: arm64: Move ec devices to an ec subdirectoryMAINTAINERS drivers/platform/arm64/Kconfig drivers/platform/arm64/Makefile +5 more+88 -824 replies
13/36arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler platearch/arm64/Kconfig drivers/platform/arm64/Kconfig drivers/platform/arm64/Makefile +4 more+415 -05 replies
14/36arm_mpam: Add support for memory controller MSC on DT platformsdrivers/platform/arm64/mpam/mpam_devices.c+47 -200 replies
15/36arm_mpam: Add the class and component structures for ris firmware describeddrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h include/linux/arm_mpam.h+576 -130 replies
16/36arm_mpam: Add MPAM MSC register layout definitionsdrivers/platform/arm64/mpam/mpam_internal.h+268 -04 replies
17/36arm_mpam: Add cpuhp callbacks to probe MSC hardwaredrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+152 -55 replies
18/36arm_mpam: Probe MSCs to find the supported partid/pmg valuesdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h include/linux/arm_mpam.h+185 -70 replies
19/36arm_mpam: Add helpers for managing the locking around the mon_sel registersdrivers/platform/arm64/mpam/mpam_internal.h+56 -10 replies
20/36arm_mpam: Probe the hardware features resctrl supportsdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+206 -15 replies
21/36arm_mpam: Merge supported features during mpam_enable() into mpam_classdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+223 -01 reply
22/36arm_mpam: Reset MSC controls from cpu hp callbacksdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+131 -12 replies
23/36arm_mpam: Add a helper to touch an MSC from any CPUdrivers/platform/arm64/mpam/mpam_devices.c+34 -30 replies
24/36arm_mpam: Extend reset logic to allow devices to be reset any timedrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+61 -22 replies
25/36arm_mpam: Register and enable IRQsdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+307 -610 replies
26/36arm_mpam: Use a static key to indicate when mpam is enableddrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+16 -00 replies
27/36arm_mpam: Allow configuration to be applied and restored during cpu onlinedrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+234 -288 replies
28/36arm_mpam: Probe and reset the rest of the featuresdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+189 -20 replies
29/36arm_mpam: Add helpers to allocate monitorsdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+37 -00 replies
30/36arm_mpam: Add mpam_msmon_read() to read monitor valuedrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+240 -01 reply
31/36arm_mpam: Track bandwidth counter state for overflow and power managementdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+201 -170 replies
32/36arm_mpam: Probe for long/lwd mbwu countersdrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+30 -10 replies
33/36arm_mpam: Use long MBWU counters if supporteddrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+86 -112 replies
34/36arm_mpam: Add helper to reset saved mbwu statedrivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/mpam_internal.h+51 -30 replies
35/36arm_mpam: Add kunit test for bitmap resetdrivers/platform/arm64/mpam/Kconfig drivers/platform/arm64/mpam/mpam_devices.c drivers/platform/arm64/mpam/test_mpam_devices.c+85 -00 replies
36/36arm_mpam: Add kunit tests for props_mismatch()drivers/platform/arm64/mpam/mpam_internal.h drivers/platform/arm64/mpam/test_mpam_devices.c+329 -10 replies

Reviews trailers per patch

8 of 36 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronGavin ShanSudeep HollaRohit Mathew
1/36R-b R-b
2/36R-b R-b
3/36R-b R-b
4/36
5/36R-b
6/36R-b
7/36R-b
8/36R-b
9/36R-b
10/36
11/36
12/36
13/36
14/36
15/36
16/36
17/36
18/36
19/36
20/36
21/36
22/36
23/36
24/36
25/36T-b
26/36
27/36
28/36
29/36
30/36
31/36
32/36
33/36
34/36
35/36
36/36

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [RFC PATCH 00/36] arm_mpam: Add basic mpam driver

Hello,

This is just enough MPAM driver for the ACPI and DT pre-requisites. It doesn't contain any of the resctrl code, meaning you can't actually drive it from user-space yet.

This is the initial group of patches that allows the resctrl code to be built on top. Including that will increase the number of trees that may need to coordinate, so breaking it up make sense.

The locking looks very strange - but is influenced by the 'mpam-fb' firmware interface specification that is still alpha. That thing needs to wait for an interrupt after every system register write, which significantly impacts the driver. Some features just won't work, e.g. reading the monitor registers via perf.
The aim is to not have to make invasive changes to the locking to support the firmware interface, hence it looks strange from day-1.

I've not found a platform that can test all the behaviours around the monitors, so this is where I'd expect the most bugs.

It's unclear where in the tree this should be put. It affects memory bandwidth and cache allocation, but doesn't (yet) interact with perf. The main interaction is with resctrl in fs/resctrl - but there will be no filesystem code in here. Its also likely there will be other in-kernel users. (in-kernel MSC emulation by KVM being an obvious example).
(I'm not a fan of drivers/resctrl or drivers/mpam - its not the sort of thing
that justifies being a 'subsystem'.)

For now, I've put this under drivers/platform/arm64. Other ideas welcome.

The first three patches are currently a series on the list, the PPTT stuff has previously been posted - this is where the users of those helpers appear.

The MPAM spec that describes all the system and MMIO registers can be found here:
https://developer.arm.com/documentation/ddi0598/db/?lang=en
(Ignored the 'RETIRED' warning - that is just arm moving the documentation
around. This document has the best overview)

This series is based on v6.16-rc4, and can be retrieved from:
https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/driver/rfc

The rest of the driver can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/snapshot/v6.16-rc4

What is MPAM? Set your time-machine to 2020:
https://lore.kernel.org/lkml/[email protected]/

Bugs welcome,
Thanks,

James Morse (31):
cacheinfo: Add arch hook to compress CPU h/w id into 32 bits for
cache-id
arm64: cacheinfo: Provide helper to compress MPIDR value into u32
cacheinfo: Expose the code to generate a cache-id from a device_node ACPI / PPTT: Add a helper to fill a cpumask from a processor container ACPI / PPTT: Stop acpi_count_levels() expecting callers to clear
levels
ACPI / PPTT: Find cache level by cache-id
ACPI / PPTT: Add a helper to fill a cpumask from a cache_id
arm64: kconfig: Add Kconfig entry for MPAM
ACPI / MPAM: Parse the MPAM table
platform: arm64: Move ec devices to an ec subdirectory
arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate
arm_mpam: Add the class and component structures for ris firmware
described
arm_mpam: Add MPAM MSC register layout definitions
arm_mpam: Add cpuhp callbacks to probe MSC hardware
arm_mpam: Probe MSCs to find the supported partid/pmg values
arm_mpam: Add helpers for managing the locking around the mon_sel
registers
arm_mpam: Probe the hardware features resctrl supports
arm_mpam: Merge supported features during mpam_enable() into
mpam_class
arm_mpam: Reset MSC controls from cpu hp callbacks
arm_mpam: Add a helper to touch an MSC from any CPU
arm_mpam: Extend reset logic to allow devices to be reset any time
arm_mpam: Register and enable IRQs
arm_mpam: Use a static key to indicate when mpam is enabled
arm_mpam: Allow configuration to be applied and restored during cpu
online
arm_mpam: Probe and reset the rest of the features
arm_mpam: Add helpers to allocate monitors
arm_mpam: Add mpam_msmon_read() to read monitor value
arm_mpam: Track bandwidth counter state for overflow and power
management
arm_mpam: Add helper to reset saved mbwu state
arm_mpam: Add kunit test for bitmap reset
arm_mpam: Add kunit tests for props_mismatch()

Rob Herring (2):
cacheinfo: Set cache 'id' based on DT data
dt-bindings: arm: Add MPAM MSC binding

Rohit Mathew (2):
arm_mpam: Probe for long/lwd mbwu counters
arm_mpam: Use long MBWU counters if supported

Shanker Donthineni (1):
arm_mpam: Add support for memory controller MSC on DT platforms

 .../devicetree/bindings/arm/arm,mpam-msc.yaml |  227 ++
 MAINTAINERS                                   |    6 +-
 arch/arm64/Kconfig                            |   19 +
 arch/arm64/include/asm/cache.h                |   17 +
 drivers/acpi/arm64/Kconfig                    |    3 +
 drivers/acpi/arm64/Makefile                   |    1 +
 drivers/acpi/arm64/mpam.c                     |  365 +++
 drivers/acpi/pptt.c                           |  240 +-
 drivers/acpi/tables.c                         |    2 +-
 drivers/base/cacheinfo.c                      |   57 +
 drivers/platform/arm64/Kconfig                |   73 +-
 drivers/platform/arm64/Makefile               |   10 +-
 drivers/platform/arm64/ec/Kconfig             |   73 +
 drivers/platform/arm64/ec/Makefile            |   10 +
 .../platform/arm64/{ => ec}/acer-aspire1-ec.c |    0
 .../arm64/{ => ec}/huawei-gaokun-ec.c         |    0
 .../arm64/{ => ec}/lenovo-yoga-c630.c         |    0
 drivers/platform/arm64/mpam/Kconfig           |   23 +
 drivers/platform/arm64/mpam/Makefile          |    4 +
 drivers/platform/arm64/mpam/mpam_devices.c    | 2910 +++++++++++++++++
 drivers/platform/arm64/mpam/mpam_internal.h   |  697 ++++
 .../platform/arm64/mpam/test_mpam_devices.c   |  390 +++
 include/linux/acpi.h                          |   17 +
 include/linux/arm_mpam.h                      |   56 +
 include/linux/cacheinfo.h                     |    1 +
 25 files changed, 5117 insertions(+), 84 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml
 create mode 100644 drivers/acpi/arm64/mpam.c
 create mode 100644 drivers/platform/arm64/ec/Kconfig
 create mode 100644 drivers/platform/arm64/ec/Makefile
 rename drivers/platform/arm64/{ => ec}/acer-aspire1-ec.c (100%)
 rename drivers/platform/arm64/{ => ec}/huawei-gaokun-ec.c (100%)
 rename drivers/platform/arm64/{ => ec}/lenovo-yoga-c630.c (100%)
 create mode 100644 drivers/platform/arm64/mpam/Kconfig
 create mode 100644 drivers/platform/arm64/mpam/Makefile
 create mode 100644 drivers/platform/arm64/mpam/mpam_devices.c
 create mode 100644 drivers/platform/arm64/mpam/mpam_internal.h
 create mode 100644 drivers/platform/arm64/mpam/test_mpam_devices.c
 create mode 100644 include/linux/arm_mpam.h
Signature · 1 line
2.39.5