Skip to content

RFC Remove unused EFI runtime APIs

Ard Biesheuvel linux-arm-kernel linux-efi linux-riscv linux-rtc lkml loongarch xen-devel 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3efi-rtc: Remove wakeup functionalitydrivers/rtc/rtc-efi.c+2 -748 replies
2/3efi/test: Don't bother pseudo-testing unused EFI servicesdrivers/firmware/efi/test/efi_test.c+2 -1060 replies
3/3efi: Remove support for pointless, unused EFI servicesarch/x86/platform/efi/efi_64.c drivers/firmware/efi/runtime-wrappers.c drivers/xen/efi.c +1 more+0 -1521 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchFeng TangStefano Stabellini
1/3T-b
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/3] Remove unused EFI runtime APIs

From: Ard Biesheuvel <[email protected]>

Using EFI runtime services to program the RTC to wake up the system is supported in theory, but rarely works in practice. Fortunately, this functionality is rarely [if ever] used to begin with so we can just drop it. (Note that the EFI rtc driver is not used by x86, which programs the CMOS rtc directly)

The same applies to GetNextHighMonoCount(), which, if implemented, usually relies on SetVariable() under the hood *, which is often not supported at runtime by non-x86 platforms. But it has no known users either so let's drop support for it as well.

This means we need to drop the slightly pointless tests for it too.

* EDK2 based EFI implementations usually have a MTC variable carrying the monotonic counter variable, which is therefore not truly monotonic, given that SetVariable() will happily overwrite it.

Cc Heinrich Schuchardt <[email protected]>
Cc Feng Tang <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Stefano Stabellini <[email protected]>
Cc Oleksandr Tyshchenko <[email protected]>
Cc Sunil V L <[email protected]>
Cc Bibo Mao <[email protected]>

Ard Biesheuvel (3):
efi-rtc: Remove wakeup functionality
efi/test: Don't bother pseudo-testing unused EFI services
efi: Remove support for pointless, unused EFI services

 arch/x86/platform/efi/efi_64.c          |  22 ----
 drivers/firmware/efi/runtime-wrappers.c |  68 ------------
 drivers/firmware/efi/test/efi_test.c    | 108 +-------------------
 drivers/rtc/rtc-efi.c                   |  76 +-------------
 drivers/xen/efi.c                       |  56 ----------
 include/linux/efi.h                     |   6 --
 6 files changed, 4 insertions(+), 332 deletions(-)
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog