KVM: arm64: nv: Userspace register visibility fixes
Status from this message: Applied to next, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | KVM: arm64: Make RVBAR_EL2 accesses UNDEFarch/ | +1 | 0 replies | |
| 2/11 | KVM: arm64: Don't advertise ICH_*_EL2 registers through GET_ONE_REGarch/ | +37 | 0 replies | |
| 3/11 | KVM: arm64: Define constant value for ICC_SRE_EL2arch/ arch/ | +4 | 0 replies | |
| 4/11 | KVM: arm64: Define helper for ICH_VTR_EL2arch/ arch/ | +16 | 0 replies | |
| 5/11 | KVM: arm64: Let GICv3 save/restore honor visibility attributearch/ | +6 | 0 replies | |
| 6/11 | KVM: arm64: Expose GICv3 EL2 registers via KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGSarch/ | +113 | 0 replies | |
| 7/11 | KVM: arm64: Condition FGT registers on feature availabilityarch/ | +15 | 0 replies | |
| 8/11 | KVM: arm64: Advertise FGT2 registers to userspacearch/ | +15 | 0 replies | |
| 9/11 | KVM: arm64: selftests: get-reg-list: Simplify feature dependencytools/ | +22 | 1 reply | |
| 10/11 | KVM: arm64: selftests: get-reg-list: Add base EL2 registerstools/ | +145 | 0 replies | |
| 11/11 | KVM: arm64: Document registers exposed via KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGSDocumentation/ | +58 | 0 replies |
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by.
| Patch | Itaru Kitayama |
|---|---|
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | T-b |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] KVM: arm64: nv: Userspace register visibility fixes
Peter recently pointed out that we don't expose the EL2 GICv3 registers in a consistent manner, as they are presented through the ONE_REG interface instead of KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS, despite the latter already exposing the EL1 GICv3 regs.
While I was looking at this, I ended up finding a small number of equally small problems:
- RVBAR_EL2 shouldn't be a thing at all
- FEAT_FGT registers should only be exposed to userspace if the feature is presented to the guest (and actually exists)
- FEAT_FGT2 registers are not exposed at all, and that's bad (though the machine that has FGT2 hasn't been built yet)
- Nothing documents which registers are exposed by KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS
So I cooked up a handful of fixes for those. And because I was feeling generous, I hacked the get-reg-list test to check for the EL2 registers reported via ONE_REG /mindblown/.
Eric, I'd really appreciate if you could give this a go with QEMU to check that you can now correctly get to the GIC El2 registers via the expected interface.
Marc Zyngier (11):
KVM: arm64: Make RVBAR_EL2 accesses UNDEF
KVM: arm64: Don't advertise ICH_*_EL2 registers through GET_ONE_REG
KVM: arm64: Define constant value for ICC_SRE_EL2
KVM: arm64: Define helper for ICH_VTR_EL2
KVM: arm64: Let GICv3 save/restore honor visibility attribute
KVM: arm64: Expose GICv3 EL2 registers via
KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS
KVM: arm64: Condition FGT registers on feature availability
KVM: arm64: Advertise FGT2 registers to userspace
KVM: arm64: selftests: get-reg-list: Simplify feature dependency
KVM: arm64: selftests: get-reg-list: Add base EL2 registers
KVM: arm64: Document registers exposed via
KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS
.../virt/kvm/devices/arm-vgic-v3.rst | 63 +++++- arch/arm64/kvm/sys_regs.c | 111 ++++++---- arch/arm64/kvm/vgic-sys-reg-v3.c | 121 ++++++++++- arch/arm64/kvm/vgic/vgic.h | 18 ++ .../selftests/kvm/arm64/get-reg-list.c | 197 +++++++++++++++--- 5 files changed, 432 insertions(+), 78 deletions(-)
Signature · 1 line
2.39.2