Skip to content

RFC system/win32: Remove unused Error argument in qemu_socket_[un]select()

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2system/os-win32: Remove unused Error** argument in qemu_socket_unselectinclude/system/os-win32.h io/channel-socket.c util/oslib-win32.c+6 -65 replies
2/2system/os-win32: Remove unused Error** argument in qemu_socket_selectinclude/system/os-win32.h util/aio-win32.c util/oslib-win32.c+7 -103 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchManos Pitsidianakis
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/2] system/win32: Remove unused Error argument in qemu_socket_[un]select()

We should use Error** more, but in this case it is always NULL so we never really care. Remove the argument...

Philippe Mathieu-Daudé (2):
system/os-win32: Remove unused Error** argument in
qemu_socket_unselect
system/os-win32: Remove unused Error** argument in qemu_socket_select

 include/system/os-win32.h |  4 ++--
 io/channel-socket.c       |  4 ++--
 util/aio-win32.c          |  2 +-
 util/oslib-win32.c        | 17 +++++++----------
 4 files changed, 12 insertions(+), 15 deletions(-)
Signature · 1 line
2.49.0