Skip to content

staging: rtl8723bs: get rid of struct hal_ops

Michael Straube linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11staging: rtl8723bs: remove function pointer SetHalODMVarHandlerdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+3 -110 replies
2/11staging: rtl8723bs: remove wrapper rtl8723b_SetHalODMVardrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -70 replies
3/11staging: rtl8723bs: remove function pointer hal_notch_filterdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+3 -50 replies
4/11staging: rtl8723bs: remove function pointer c2h_handlerdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -70 replies
5/11staging: rtl8723bs: remove macro FillH2CCmddrivers/staging/rtl8723bs/include/rtl8723b_cmd.h+0 -10 replies
6/11staging: rtl8723bs: remove function pointer fill_h2c_cmddrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -100 replies
7/11staging: rtl8723bs: remove macro hal_xmit_handlerdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/rtl8723b_xmit.h+1 -20 replies
8/11staging: rtl8723bs: remove function pointer xmit_thread_handlerdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -60 replies
9/11staging: rtl8723bs: remove function pointer hal_reset_security_enginedrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/include/hal_intf.h+0 -100 replies
10/11staging: rtl8723bs: remove function pointer c2h_id_filterdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -30 replies
11/11staging: rtl8723bs: remove struct hal_opsdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/drv_types.h +4 more+0 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] staging: rtl8723bs: get rid of struct hal_ops

This series removes the remaining function pointers from the hal_ops structure, and finally removes the structure itself. This reduces code complexity and thereby improves readability, as the hal_ops structure is just an unnecessary layer of abstraction.

The patches have been compile-tested only, due to lack of hardware.

Michael Straube (11):
staging: rtl8723bs: remove function pointer SetHalODMVarHandler
staging: rtl8723bs: remove wrapper rtl8723b_SetHalODMVar
staging: rtl8723bs: remove function pointer hal_notch_filter
staging: rtl8723bs: remove function pointer c2h_handler
staging: rtl8723bs: remove macro FillH2CCmd
staging: rtl8723bs: remove function pointer fill_h2c_cmd
staging: rtl8723bs: remove macro hal_xmit_handler
staging: rtl8723bs: remove function pointer xmit_thread_handler
staging: rtl8723bs: remove function pointer hal_reset_security_engine
staging: rtl8723bs: remove function pointer c2h_id_filter
staging: rtl8723bs: remove struct hal_ops

 drivers/staging/rtl8723bs/hal/hal_intf.c      | 33 ++++---------------
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 26 +--------------
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  8 -----
 drivers/staging/rtl8723bs/include/drv_types.h |  1 -
 drivers/staging/rtl8723bs/include/hal_intf.h  | 13 +-------
 .../staging/rtl8723bs/include/rtl8723b_cmd.h  |  1 -
 .../staging/rtl8723bs/include/rtl8723b_hal.h  |  1 -
 .../staging/rtl8723bs/include/rtl8723b_xmit.h |  1 -
 drivers/staging/rtl8723bs/include/sdio_hal.h  |  2 --
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  |  2 --
 10 files changed, 8 insertions(+), 80 deletions(-)
Signature · 1 line
2.50.1

Read the cover letter in its thread