Skip to content

hw/i386/amd_iommu: Cleanups and fixes

Sairaj Kodilkar qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 7 repliesIn review
  2. v26 patches 6 repliesSuperseded
  3. v17 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- Used VMSTATE_UNUSED() to maintain migration compatibility when ats_enabled flag is removed [Phil].
- Simplified the amdvi_writew [Phil].
v2: https://lore.kernel.org/qemu-devel/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/i386/amd_iommu: Fix MMIO register write tracinghw/i386/amd_iommu.c+18 -52 replies
2/6hw/i386/amd_iommu: Remove unused and wrongly set ats_enabled fieldhw/i386/amd_iommu.c hw/i386/amd_iommu.h+2 -41 reply
3/6hw/i386/amd_iommu: Move IOAPIC memory region initialization to the endhw/i386/amd_iommu.c+3 -30 replies
4/6hw/i386/amd_iommu: Fix amdvi_write*()hw/i386/amd_iommu.c+18 -30 replies
5/6hw/i386/amd_iommu: Support MMIO writes to the status registerhw/i386/amd_iommu.c+3 -00 replies
6/6hw/i386/amd_iommu: Fix event log generationhw/i386/amd_iommu.c hw/i386/amd_iommu.h+36 -90 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchVasant HegdePhilippe Mathieu-Daudé
1/6R-b R-b
2/6R-b R-b
3/6R-b
4/6
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] hw/i386/amd_iommu: Cleanups and fixes

This series provides few cleanups and fixes for the amd iommu

Changes since v2:
- Used VMSTATE_UNUSED() to maintain migration compatibility when ats_enabled flag is removed [Phil].
- Simplified the amdvi_writew [Phil].
v2: https://lore.kernel.org/qemu-devel/[email protected]/

Changes since v1:
- Dropped top two patches which depend on the Alejandro's changes and rebased remaining patches on top of v10.1.0-rc0 [Phil].
- Added a patch to fix amdvi_write*() [Ethon].
- Reset event log head and tail when guest writes to event log base register [Ethon].
- Considered "evtlog_intr" flag while generating event log interrupt [Ethon].
- Fixed comment [Ethon].
v1: https://lore.kernel.org/qemu-devel/[email protected]/

Base commit: 9e601684dc24a521bb1d23215a63e5c6e79ea0bb (v10.1.0-rc0)

Sairaj Kodilkar (6):
hw/i386/amd_iommu: Fix MMIO register write tracing hw/i386/amd_iommu: Remove unused and wrongly set ats_enabled field hw/i386/amd_iommu: Move IOAPIC memory region initialization to the end hw/i386/amd_iommu: Fix amdvi_write*()
hw/i386/amd_iommu: Support MMIO writes to the status register hw/i386/amd_iommu: Fix event log generation

 hw/i386/amd_iommu.c | 102 ++++++++++++++++++++++++++++++++++----------
 hw/i386/amd_iommu.h |   2 +-
 2 files changed, 80 insertions(+), 24 deletions(-)
Signature · 1 line
2.34.1