drm: Fix bug in panel driver, update MIPI support macros
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest4 patches 5 repliesIn review
- v54 patches 4 repliesSuperseded
- v44 patches 9 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 2/2 | 0 of 4 patches | 1 reply | Superseded | |
| v3 posting 1/2 | 4 patches | 1 reply | Superseded |
Changes in v6 from the cover letter
- Fix various style and kerneldoc issues in patch 1/4
- Fix typo mpi_dsi_dual... -> mipi_dsi_dual...
- Fix incorrectly named "data" and "len" variables
- Make _seq argument of mipi_dsi_dual_dcs_write_seq_multi macro variadic
- Remove duplicate definition of mipi_dsi_dual_dcs_write_seq_multi macro from novatek display driver
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drm: Create mipi_dsi_dual* macrosdrivers/ drivers/ include/ | +541 | 2 replies | |
| 2/4 | drm/panel: jdi-lpm102a188a: Fix bug and clean up driverdrivers/ | +59 | 1 reply | |
| 3/4 | drm: Remove unused MIPI write seq and chatty functionsdrivers/ include/ | +3 | 1 reply | |
| 4/4 | drm: docs: Update task from drm TODO listDocumentation/ | +11 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Dmitry Baryshkov | Douglas Anderson | Diogo Ivo |
|---|---|---|---|
| 1/4 | R-b | R-b | |
| 2/4 | R-b | R-b T-b | |
| 3/4 | R-b | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/4] drm: Fix bug in panel driver, update MIPI support macros
This series removes the unintuitive mipi_dsi_generic_write_seq() macro and related mipi_dsi_generic_write_chatty() method from the drm subsystem. This is in accordance with a TODO item from Douglas Anderson in the drm subsystem documentation. Tejas Vipin (among others) has largely spearheaded this effort up until now, converting MIPI panel drivers one at a time.
The second patch of the series removes the last remaining references to mipi_dsi_generic_write_seq() in the jdi-lpm102a188a driver and updates the driver to use the undeprecated _multi variants of MIPI functions. It fixes a bug in the driver's unprepare function and cleans up duplicated code using the new mipi_dsi_dual* macros introduced in the first patch.
changes to v6:
- Fix various style and kerneldoc issues in patch 1/4
- Fix typo mpi_dsi_dual... -> mipi_dsi_dual...
- Fix incorrectly named "data" and "len" variables
- Make _seq argument of mipi_dsi_dual_dcs_write_seq_multi macro variadic
- Remove duplicate definition of mipi_dsi_dual_dcs_write_seq_multi macro from novatek display driver
changes to v5:
- Rework mipi_dsi_dual to explicitly not support passing macros into _func and add "dual" variants of the generic and dcs write macros.
- Make jdi-lpm102a188a use the new mipi_dsi_dual_generic_write_seq_multi macro.
- Make local struct variable in jdi-lpm102a188a conform to reverse christmas tree order.
changes to v4:
- Fix whitespace (I forgot to run checkpatch. Thanks for your patience as I familiarize myself with the kernel development process)
- Initialize mipi_dsi_multi_context struct
changes to v3:
- Define new mipi_dsi_dual macro in drm_mipi_dsi.h to reduce code duplication.
- Fix bug in lpm102a188a panel driver's unprepare function which causes it to return a nonsensical value.
- Make lpm102a188a panel driver's unprepare function send "display off" and "enter sleep mode" commands to both serial interfaces regardless of whether an error occurred when sending the last command.
changes to v2:
- Remove all usages of deprecated MIPI functions from jdi-lpm102a188a driver instead of just mipi_dsi_generic_write_seq().
- Update TODO item in drm documentation instead of removing it entirely.
Brigham Campbell (4):
drm: Create mipi_dsi_dual* macros
drm/panel: jdi-lpm102a188a: Fix bug and clean up driver
drm: Remove unused MIPI write seq and chatty functions
drm: docs: Update task from drm TODO list
Documentation/gpu/todo.rst | 22 +- drivers/gpu/drm/drm_mipi_dsi.c | 82 +- drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 196 ++--- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 804 +++++++++--------- include/drm/drm_mipi_dsi.h | 118 ++- 5 files changed, 614 insertions(+), 608 deletions(-)
base-commit: ca2a6abdaee43808034cdb218428d2ed85fd3db8
Signature · 1 line
2.50.1