Skip to content

perf: Clean ups and simplifications

Steven Rostedt linux-perf-users linux-trace-kernel lkml 2 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/25 patches 11 repliesApplied
  2. v1 posting 1/25 patches 0 repliesSuperseded

Patches in v1 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/5perf: Remove get_perf_callchain() init_nr argumentinclude/linux/perf_event.h kernel/bpf/stackmap.c kernel/events/callchain.c +1 more+10 -100 replies
2/5perf: Have get_perf_callchain() return NULL if crosstask and user are setkernel/events/callchain.c+5 -50 replies
3/5perf: Use current->flags & PF_KTHREAD|PF_USER_WORKER instead of current->mm == NULLkernel/events/callchain.c kernel/events/core.c+5 -510 replies
4/5perf: Simplify get_perf_callchain() user logickernel/events/callchain.c+8 -100 replies
5/5perf: Skip user unwind if the task is a kernel threadkernel/events/core.c+2 -10 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchNamhyung KimAlexei StarovoitovGuenter Roeck
1/5A-b A-b
2/5
3/5T-b
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RESEND][PATCH 0/5] perf: Clean ups and simplifications

This is a resend from: https://lore.kernel.org/linux-trace-kernel/[email protected]/

It cleanly applied on top of the latest tip/perf/core:
448f97fba901 ("perf: Convert mmap() refcounts to refcount_t")

The ongoing work to support sframes[1] in the kernel required a few clean ups to the perf kernel side. Instead of having these changes in the ongoing work, there's no reason they cannot be applied now.

These are just clean ups to the perf code to help simplify the updates that will be made later.

[1] https://lore.kernel.org/linux-trace-kernel/[email protected]

Josh Poimboeuf (4):
perf: Remove get_perf_callchain() init_nr argument
perf: Have get_perf_callchain() return NULL if crosstask and user are set
perf: Simplify get_perf_callchain() user logic
perf: Skip user unwind if the task is a kernel thread

Steven Rostedt (1):

      perf: Use current->flags & PF_KTHREAD|PF_USER_WORKER instead of current->mm == NULL

----

 include/linux/perf_event.h |  2 +-
 kernel/bpf/stackmap.c      |  4 ++--
 kernel/events/callchain.c  | 40 +++++++++++++++++++---------------------
 kernel/events/core.c       |  9 +++++----
 4 files changed, 27 insertions(+), 28 deletions(-)