Skip to content

netconsole: reuse netpoll_parse_ip_addr in configfs helpers

Breno Leitao lkml netdev 4 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected] change-id 20250718-netconsole_ref-c1f7254cfb51

Versions newest first

  1. v4 Latest4 patches 0 repliesApplied 4/4
  2. v35 patches 1 replySuperseded 1 of 5 applied
  3. v25 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches1 replySuperseded

Changes in v4 from the cover letter

- Check the end string returned by netpoll_parse_ip_addr(), and fail
if it is different than 0 and \n. (Jakub)
* Also removed Simon reviewed-by given I changed the code slightly.
- Link to v3: https://lore.kernel.org/r/[email protected]

Patches in v4 All 4 applied

#Subject and filesSizeRepliesApplied
1/4netconsole: move netpoll_parse_ip_addr() earlier for reusedrivers/net/netconsole.c+20 -200 repliesApplied
2/4netconsole: add support for strings with new line in netpoll_parse_ip_addrdrivers/net/netconsole.c+20 -130 repliesApplied
3/4netconsole: use netpoll_parse_ip_addr in local_ip_storedrivers/net/netconsole.c+5 -170 repliesApplied
4/4netconsole: use netpoll_parse_ip_addr in local_ip_storedrivers/net/netconsole.c+5 -170 repliesApplied

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchSimon Horman
1/4R-b
2/4
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net-next v4 0/4] netconsole: reuse netpoll_parse_ip_addr in configfs helpers

This patchset refactors the IP address parsing logic in the netconsole driver to eliminate code duplication and improve maintainability. The changes centralize IPv4 and IPv6 address parsing into a single function (netpoll_parse_ip_addr). For that, it needs to teach netpoll_parse_ip_addr() to handle strings with newlines, which is the type of string coming from configfs.

Background

The netconsole driver currently has duplicate IP address parsing logic in both local_ip_store() and remote_ip_store() functions. This duplication increases the risk of inconsistencies and makes the code harder to maintain.

Benefits

* Reduced code duplication: ~40 lines of duplicate parsing logic eliminated
* Improved robustness: Centralized parsing reduces the chance of inconsistencies
* Easier to maintain: Code follow more the netdev way

---
Changes in v4:
- Check the end string returned by netpoll_parse_ip_addr(), and fail
if it is different than 0 and \n. (Jakub)
* Also removed Simon reviewed-by given I changed the code slightly.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Avoid #ifdef and use if (IS_ENABLED()) instead (Simon)
- Assing an int to a boolean using !! (Simon)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Moved the netpoll_parse_ip_addr() to outside the dynamic block (Jakub)
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Breno Leitao (4):
netconsole: move netpoll_parse_ip_addr() earlier for reuse
netconsole: add support for strings with new line in netpoll_parse_ip_addr
netconsole: use netpoll_parse_ip_addr in local_ip_store
netconsole: use netpoll_parse_ip_addr in local_ip_store

 drivers/net/netconsole.c | 91 ++++++++++++++++++++----------------------------
 1 file changed, 37 insertions(+), 54 deletions(-)

---
base-commit: 37816488247ddddbc3de113c78c83572274b1e2e
change-id: 20250718-netconsole_ref-c1f7254cfb51

Best regards,

Signature · 1 line
Breno Leitao <[email protected]>