drm/v3d: General job locking improvements + race-condition fixes
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected] change-id 20250718-v3d-queue-lock-59babfb548bcVersions newest first
- v3 Latest6 patches 1 replyApplied
- v26 patches 13 repliesSuperseded
- v16 patches 1 replySuperseded
Changes in v3 from the cover letter
- [1/6, 2/6, 3/6, 5/6] Add Melissa's R-b.
- [1/6] Improve the commit message (Melissa Wen)
- [2/6] Use &job->base instead of to_v3d_job(sched_job)
- [6/6] Fix the loop index (s/q/i) (Melissa Wen)
- Link to v2: https://lore.kernel.org/r/[email protected]
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | drm/v3d: Store a pointer to `struct v3d_file_priv` inside each jobdrivers/ drivers/ drivers/ | +8 | 0 replies | |
| 2/6 | drm/v3d: Store the active job inside the queue's statedrivers/ drivers/ drivers/ +1 more | +38 | 0 replies | |
| 3/6 | drm/v3d: Replace a global spinlock with a per-queue spinlockdrivers/ drivers/ drivers/ +2 more | +20 | 0 replies | |
| 4/6 | drm/v3d: Address race-condition between per-fd GPU stats and fd releasedrivers/ drivers/ drivers/ | +21 | 0 replies | |
| 5/6 | drm/v3d: Synchronous operations can't timeoutdrivers/ | +4 | 0 replies | |
| 6/6 | drm/v3d: Protect per-fd reset counter against fd releasedrivers/ | +17 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Iago Toral Quiroga | Melissa Wen |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | |
| 5/6 | R-b | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6] drm/v3d: General job locking improvements + race-condition fixes
This patch series was initially motivated by a race condition (exposed in PATCH 4/6) where we lacked synchronization for job->file access. This led to use-after-free issues when a file descriptor was closed while a job was still running.
However, beyond fixing this specific race, the series introduces broader improvements to active job management and locking. While PATCH 1/6, 2/6, and 5/6 are primarily code refactors, PATCH 3/6 brings a significant change to the locking scheme. Previously, all queues shared the same spinlock, which caused unnecessary contention during high GPU usage across different queues. PATCH 3/6 allows queues to operate more independently.
Finally, PATCH 6/6 addresses a similar race condition to PATCH 4/6, but this time, on the per-file descriptor reset counter.
Best Regards,
- Maíra
---
v1 -> v2:
- Add Iago's R-b to all patches.
- Rebase on top of drm-misc-next.
- Link to v1: https://lore.kernel.org/r/[email protected]
v2 -> v3:
- [1/6, 2/6, 3/6, 5/6] Add Melissa's R-b.
- [1/6] Improve the commit message (Melissa Wen)
- [2/6] Use &job->base instead of to_v3d_job(sched_job)
- [6/6] Fix the loop index (s/q/i) (Melissa Wen)
- Link to v2: https://lore.kernel.org/r/[email protected]
---
Maíra Canal (6):
drm/v3d: Store a pointer to struct v3d_file_priv inside each job drm/v3d: Store the active job inside the queue's state drm/v3d: Replace a global spinlock with a per-queue spinlock drm/v3d: Address race-condition between per-fd GPU stats and fd release drm/v3d: Synchronous operations can't timeout
drm/v3d: Protect per-fd reset counter against fd release
drivers/gpu/drm/v3d/v3d_drv.c | 14 ++++++- drivers/gpu/drm/v3d/v3d_drv.h | 22 ++++------- drivers/gpu/drm/v3d/v3d_fence.c | 11 +++--- drivers/gpu/drm/v3d/v3d_gem.c | 10 ++--- drivers/gpu/drm/v3d/v3d_irq.c | 68 +++++++++++++------------------- drivers/gpu/drm/v3d/v3d_sched.c | 85 +++++++++++++++++++++------------------- drivers/gpu/drm/v3d/v3d_submit.c | 2 +- 7 files changed, 105 insertions(+), 107 deletions(-)
---
base-commit: 7399c13f619f33dc8bdce838f3c83e88a18765ee
change-id: 20250718-v3d-queue-lock-59babfb548bc