Skip to content

steady-state: few fixes for steady state support

Luis Chamberlain kdevops 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4steady-state: use extra sparse drives when on libvirtworkflows/steady_state/Kconfig+3 -30 replies
2/4steady-state: fix identation on Makefileworkflows/steady_state/Makefile+5 -50 replies
3/4steady-state: remove extra menuworkflows/steady_state/Kconfig+0 -40 replies
4/4steady-state: quite a bit of fixesplaybooks/roles/steady_state/defaults/main.yml playbooks/roles/steady_state/tasks/main.yaml playbooks/roles/steady_state/templates/ss_bw.ini.j2 +4 more+448 -4380 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] steady-state: few fixes for steady state support

Here are some fixes on top of what ChatGPT Codex generated. It shows why it gets only a grade of B. I've now tested this code on bare metal and confirm it works. Future work generated by AI won't be merged directly but more heavily tested and vetted. We essentially need to tell the bots to test new workflows too. It would have caught some of the minor issues like these.

The conversion of scripts/workflows/precondition/prefill-fio-jobs.sh was a bit more difficult so although the an AI did that conversion I did have to carefully vet it.

I did try to revert all the work and merge this patch on top as a clean single patch but that actually ended up being a mess. Oh well. The next patch will be a better example new workflow model of a patch we can tell generative AIs to use as a good example of a new workflow to base its work on.

This goes tested against bare metal. I just created the host file myself.

Luis Chamberlain (4):
steady-state: use extra sparse drives when on libvirt
steady-state: fix identation on Makefile
steady-state: remove extra menu
steady-state: quite a bit of fixes

 .../roles/steady_state/defaults/main.yml      |  37 +-
 playbooks/roles/steady_state/tasks/main.yaml  | 314 +++++++++++++-
 .../roles/steady_state/templates/ss_bw.ini.j2 |  22 +-
 .../steady_state/templates/ss_iops.ini.j2     |  22 +-
 .../precondition/prefill-fio-jobs.sh          | 390 ------------------
 workflows/steady_state/Kconfig                |  83 +++-
 workflows/steady_state/Makefile               |  34 +-
 7 files changed, 454 insertions(+), 448 deletions(-)
 delete mode 100755 scripts/workflows/precondition/prefill-fio-jobs.sh
Signature · 1 line
2.47.2