Skip to content

selftests/damon/sysfs.py: test all parameters

SeongJae Park damon linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] selftests-damon-sysfspy-test-runtime-reduction-of-damon-parameters.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 2 repliesApplied 22/22

Patches in v1 All 22 applied

#Subject and filesSizeRepliesApplied
1/22selftests/damon/_damon_sysfs: support DAMOS watermarks setuptools/testing/selftests/damon/_damon_sysfs.py+42 -40 repliesApplied
2/22selftests/damon/_damon_sysfs: support DAMOS filters setuptools/testing/selftests/damon/_damon_sysfs.py+111 -40 repliesApplied
3/22selftests/damon/_damon_sysfs: support monitoring intervals goal setuptools/testing/selftests/damon/_damon_sysfs.py+42 -10 repliesApplied
4/22selftests/damon/_damon_sysfs: support DAMOS quota weights setuptools/testing/selftests/damon/_damon_sysfs.py+23 -10 repliesApplied
5/22selftests/damon/_damon_sysfs: support DAMOS quota goal nid setuptools/testing/selftests/damon/_damon_sysfs.py+7 -10 repliesApplied
6/22selftests/damon/_damon_sysfs: support DAMOS action dests setuptools/testing/selftests/damon/_damon_sysfs.py+55 -10 repliesApplied
7/22selftests/damon/_damon_sysfs: support DAMOS target_nid setuptools/testing/selftests/damon/_damon_sysfs.py+8 -10 repliesApplied
8/22selftests/damon/_damon_sysfs: use 2**32 - 1 as max nr_accesses and agetools/testing/selftests/damon/_damon_sysfs.py+2 -20 repliesApplied
9/22selftests/damon/drgn_dump_damon_status: dump damos->migrate_deststools/testing/selftests/damon/drgn_dump_damon_status.py+14 -00 repliesApplied
10/22selftests/damon/drgn_dump_damon_status: dump ctx->ops.idtools/testing/selftests/damon/drgn_dump_damon_status.py+6 -00 repliesApplied
11/22selftests/damon/drgn_dump_damon_status: dump DAMOS filterstools/testing/selftests/damon/drgn_dump_damon_status.py+42 -10 repliesApplied
12/22selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertiontools/testing/selftests/damon/sysfs.py+18 -80 repliesApplied
13/22selftests/damon/sysfs.py: generalize DamosQuota commit assertiontools/testing/selftests/damon/sysfs.py+20 -110 repliesApplied
14/22selftests/damon/sysfs.py: test quota goal commitmenttools/testing/selftests/damon/sysfs.py+17 -10 repliesApplied
15/22selftests/damon/sysfs.py: test DAMOS destinations commitmenttools/testing/selftests/damon/sysfs.py+9 -80 repliesApplied
16/22selftests/damon/sysfs.py: generalize DAMOS schemes commit assertiontools/testing/selftests/damon/sysfs.py+37 -222 repliesApplied
17/22selftests/damon/sysfs.py: test DAMOS filters commitmenttools/testing/selftests/damon/sysfs.py+20 -00 repliesApplied
18/22selftests/damon/sysfs.py: generalize DAMOS schemes commit assertiontools/testing/selftests/damon/sysfs.py+6 -40 repliesApplied
19/22selftests/damon/sysfs.py: generalize monitoring attributes commit assertiontools/testing/selftests/damon/sysfs.py+25 -170 repliesApplied
20/22selftests/damon/sysfs.py: generalize DAMON context commit assertiontools/testing/selftests/damon/sysfs.py+16 -120 repliesApplied
21/22selftests/damon/sysfs.py: test non-default parameters runtime committools/testing/selftests/damon/sysfs.py+53 -00 repliesApplied
22/22selftests/damon/sysfs.py: test runtime reduction of DAMON parameterstools/testing/selftests/damon/sysfs.py+14 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/22] selftests/damon/sysfs.py: test all parameters

sysfs.py tests if DAMON sysfs interface is passing the user-requested parameters to DAMON as expected. But only the default (minimum) parameters are being tested. This is partially because _damon_sysfs.py, which is the library for making the parameter requests, is not supporting the entire parameters. The internal DAMON status dump script (drgn_dump_damon_status.py) is also not dumping entire parameters. Extend the test coverage by updating parameters input and status dumping scripts to support all parameters, and writing additional tests using those.

This increased test coverage actually found one real bug
(https://lore.kernel.org/[email protected]).

First seven patches (1-7) extend _damon_sysfs.py for all parameters setup. The eight patch (8) fixes _damon_sysfs.py to use correct max nr_acceses and age values for their type. Following three patches (9-11) extend drgn_dump_damon_status.py to dump full DAMON parameters. Following nine patches (12-20) refactor sysfs.py for general testing code reuse, and extend it for full parameters check. Finally, two patches (21 and 22) add test cases in sysfs.py for full parameters testing.

SeongJae Park (22):
selftests/damon/_damon_sysfs: support DAMOS watermarks setup selftests/damon/_damon_sysfs: support DAMOS filters setup selftests/damon/_damon_sysfs: support monitoring intervals goal setup selftests/damon/_damon_sysfs: support DAMOS quota weights setup selftests/damon/_damon_sysfs: support DAMOS quota goal nid setup selftests/damon/_damon_sysfs: support DAMOS action dests setup selftests/damon/_damon_sysfs: support DAMOS target_nid setup selftests/damon/_damon_sysfs: use 2**32 - 1 as max nr_accesses and age selftests/damon/drgn_dump_damon_status: dump damos->migrate_dests selftests/damon/drgn_dump_damon_status: dump ctx->ops.id selftests/damon/drgn_dump_damon_status: dump DAMOS filters selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertion selftests/damon/sysfs.py: generalize DamosQuota commit assertion selftests/damon/sysfs.py: test quota goal commitment selftests/damon/sysfs.py: test DAMOS destinations commitment selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion selftests/damon/sysfs.py: test DAMOS filters commitment selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion selftests/damon/sysfs.py: generalize monitoring attributes commit
assertion
selftests/damon/sysfs.py: generalize DAMON context commit assertion selftests/damon/sysfs.py: test non-default parameters runtime commit selftests/damon/sysfs.py: test runtime reduction of DAMON parameters

 tools/testing/selftests/damon/_damon_sysfs.py | 301 +++++++++++++++++-
 .../selftests/damon/drgn_dump_damon_status.py |  63 +++-
 tools/testing/selftests/damon/sysfs.py        | 284 +++++++++++++----
 3 files changed, 568 insertions(+), 80 deletions(-)

base-commit: fc8066077f44a4fd43f8fdb12bc238f8fbeaa3c5

Signature · 1 line
2.39.5