Skip to content

btrfs: zoned: two small style improvements for zone finishing

Johannes Thumshirn linux-btrfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes to v2 from the cover letter

- Don't ASSERT() do_zone_finish()'s return value but set FS to r/o Link to v2:
https://lore.kernel.org/linux-btrfs/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: zoned: directly call do_zone_finish() from btrfs_zone_finish_endio_workfn()fs/btrfs/zoned.c+5 -12 replies
2/2btrfs: zoned: return error from btrfs_zone_finish_endio()fs/btrfs/inode.c fs/btrfs/zoned.c fs/btrfs/zoned.h+15 -91 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDamien Le Moal
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] btrfs: zoned: two small style improvements for zone finishing

From: Johannes Thumshirn <[email protected]>

Two small improvements for zone finish calls. The frist one changes btrfs_zone_finish_endio_workfn() to directly call do_zone_finish(), as most of the work done in btrfs_zone_finish_endio() is not needed in this context.

The second one adds error propagation to btrfs_zone_finish_endio() so it's caller btrfs_finish_one_ordered() can do error handling (in case the chunk map block group lookup failes for some reason).

Changes to v2:
- Don't ASSERT() do_zone_finish()'s return value but set FS to r/o Link to v2:
https://lore.kernel.org/linux-btrfs/[email protected]

Changes to v1:
- Remove stray bg->last_eb = NULL setting
- ASSERT() do_zone_finish() returns sucessfull
- Remove stray {}
- Remove ASSERT(!block_group) after if (!block_group)

Link to v1:
https://lore.kernel.org/linux-btrfs/[email protected]

Johannes Thumshirn (2):
btrfs: directly call do_zone_finish() from
btrfs_zone_finish_endio_workfn()
btrfs: zoned: return error from btrfs_zone_finish_endio()

 fs/btrfs/inode.c |  7 ++++---
 fs/btrfs/zoned.c | 14 ++++++++++----
 fs/btrfs/zoned.h |  9 ++++++---
 3 files changed, 20 insertions(+), 10 deletions(-)
Signature · 1 line
2.50.1