Skip to content

libsas cleanups

Damien Le Moal linux-scsi 4 versions – Applied

Status from this message: Applied to 6.17/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 8 repliesApplied
  2. v35 patches 6 repliesSuperseded
  3. v25 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches8 repliesSuperseded

Changes in v4 from the cover letter

- Corrected commit message of patch 2
- Added review tags

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5scsi: libsas: Refactor dev_is_sata()include/scsi/sas_ata.h+12 -51 reply
2/5scsi: libsas: Simplify sas_ata_wait_eh()drivers/scsi/libsas/sas_ata.c+1 -71 reply
3/5scsi: libsas: Make sas_get_ata_info() staticdrivers/scsi/libsas/sas_ata.c include/scsi/sas_ata.h+1 -71 reply
4/5scsi: libsas: Move declarations of internal functions to sas_internal.hdrivers/scsi/libsas/sas_internal.h include/scsi/sas_ata.h+75 -671 reply
5/5scsi: libsas: Use a bool for sas_deform_port() second argumentdrivers/scsi/libsas/sas_discover.c drivers/scsi/libsas/sas_internal.h drivers/scsi/libsas/sas_phy.c +1 more+12 -131 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJohn GarryJohannes ThumshirnJason Yan
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b R-b
4/5R-b R-b R-b
5/5R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] libsas cleanups

Martin, John,

While debugging an issue with the pm8001 driver, I generated these cleanup patches. No functional changes overall.

These patches are against the 6.17/scsi-staging branch of the scsi tree.

Changes from v3:
- Corrected commit message of patch 2
- Added review tags

Changes from v2:
- Modified patch 2 to remove the unnecessary check using dev_is_ata()
- Added review tags

Changes from v1:
- Added patch 1
- Modified patch 2 to not inline sas_ata_wait_eh()
- Added review tags

Damien Le Moal (5):
scsi: libsas: Refactor dev_is_sata()
scsi: libsas: Simplify sas_ata_wait_eh()
scsi: libsas: Make sas_get_ata_info() static
scsi: libsas: Move declarations of internal functions to sas_internal.h
scsi: libsas: Use a bool for sas_deform_port() second argument

 drivers/scsi/libsas/sas_ata.c      | 10 +---
 drivers/scsi/libsas/sas_discover.c |  2 +-
 drivers/scsi/libsas/sas_internal.h | 78 ++++++++++++++++++++++++-
 drivers/scsi/libsas/sas_phy.c      |  6 +-
 drivers/scsi/libsas/sas_port.c     | 13 ++---
 include/scsi/sas_ata.h             | 91 +++++-------------------------
 6 files changed, 101 insertions(+), 99 deletions(-)

base-commit: 3ea3a256ed81f95ab0f3281a0e234b01a9cae605

Signature · 1 line
2.50.1