Skip to content

can: kvaser_pciefd: Simplify identification of physical CAN interfaces

Jimmy Assarsson linux-can netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 posting 2/211 patches 2 repliesIn review
  2. v4 Latest10 patches 3 repliesIn review
  3. v2 posting 2/211 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/210 patches5 repliesSuperseded
v2 posting 1/210 patches2 repliesSuperseded
v19 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Fix transient Sparse warning
- Add tag Reviewed-by Vincent Mailhol

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10can: kvaser_pciefd: Add support to control CAN LEDs on devicedrivers/net/can/kvaser_pciefd.c+18 -00 replies
2/10can: kvaser_pciefd: Add support for ethtool set_phys_id()drivers/net/can/kvaser_pciefd.c+24 -00 replies
3/10can: kvaser_pciefd: Add intermediate variable for device struct in probe()drivers/net/can/kvaser_pciefd.c+4 -30 replies
4/10can: kvaser_pciefd: Store the different firmware version components in a structdrivers/net/can/kvaser_pciefd.c+11 -60 replies
5/10can: kvaser_pciefd: Store device channel indexdrivers/net/can/kvaser_pciefd.c+1 -00 replies
6/10can: kvaser_pciefd: Split driver into C-file and header-file.drivers/net/can/Makefile drivers/net/can/kvaser_pciefd/Makefile drivers/net/can/kvaser_pciefd/kvaser_pciefd.h +1 more+96 -710 replies
7/10can: kvaser_pciefd: Add devlink supportdrivers/net/can/Kconfig drivers/net/can/kvaser_pciefd/Makefile drivers/net/can/kvaser_pciefd/kvaser_pciefd.h +2 more+27 -43 replies
8/10can: kvaser_pciefd: Expose device firmware version via devlink info_get()drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c+24 -00 replies
9/10can: kvaser_pciefd: Add devlink port supportdrivers/net/can/kvaser_pciefd/kvaser_pciefd.h drivers/net/can/kvaser_pciefd/kvaser_pciefd_core.c drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c+37 -00 replies
10/10Documentation: devlink: add devlink documentation for the kvaser_pciefd driverDocumentation/networking/devlink/index.rst Documentation/networking/devlink/kvaser_pciefd.rst+25 -00 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchAxel ForsmanVincent Mailhol
1/10R-b R-b
2/10R-b R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/10] can: kvaser_pciefd: Simplify identification of physical CAN interfaces

This patch series simplifies the process of identifying which network interface (can0..canX) corresponds to which physical CAN channel on Kvaser PCIe based CAN interfaces.

Changes in v4:
- Fix transient Sparse warning
- Add tag Reviewed-by Vincent Mailhol

Changes in v3:
- Fixed typo; kvaser_pcied -> kvaser_pciefd in documentation patch

Changes in v2:
- Replace use of netdev.dev_id with netdev.dev_port
- Formatting and refactoring
- New patch with devlink documentation

Jimmy Assarsson (10):
can: kvaser_pciefd: Add support to control CAN LEDs on device
can: kvaser_pciefd: Add support for ethtool set_phys_id()
can: kvaser_pciefd: Add intermediate variable for device struct in

    probe()
  can: kvaser_pciefd: Store the different firmware version components in
    a struct
  can: kvaser_pciefd: Store device channel index
  can: kvaser_pciefd: Split driver into C-file and header-file.
  can: kvaser_pciefd: Add devlink support
  can: kvaser_pciefd: Expose device firmware version via devlink
    info_get()

can: kvaser_pciefd: Add devlink port support
Documentation: devlink: add devlink documentation for the
kvaser_pciefd driver

 Documentation/networking/devlink/index.rst    |   1 +
 .../networking/devlink/kvaser_pciefd.rst      |  24 +++
 drivers/net/can/Kconfig                       |   1 +
 drivers/net/can/Makefile                      |   2 +-
 drivers/net/can/kvaser_pciefd/Makefile        |   3 +
 drivers/net/can/kvaser_pciefd/kvaser_pciefd.h |  96 ++++++++++++
 .../kvaser_pciefd_core.c}                     | 144 +++++++++---------
 .../can/kvaser_pciefd/kvaser_pciefd_devlink.c |  60 ++++++++
 8 files changed, 257 insertions(+), 74 deletions(-)
 create mode 100644 Documentation/networking/devlink/kvaser_pciefd.rst
 create mode 100644 drivers/net/can/kvaser_pciefd/Makefile
 create mode 100644 drivers/net/can/kvaser_pciefd/kvaser_pciefd.h
 rename drivers/net/can/{kvaser_pciefd.c => kvaser_pciefd/kvaser_pciefd_core.c} (96%)
 create mode 100644 drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
Signature · 1 line
2.49.0