Analog connector support in DC
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest20 patches 40 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | drm/amd/display: Determine DRM connector type more accuratelydrivers/ | +16 | 10 replies | |
| 2/20 | drm/amd/display: Add analog bit to edid_capsdrivers/ drivers/ | +6 | 0 replies | |
| 3/20 | drm/amd/display: Introduce MAX_LINK_ENCODERSdrivers/ drivers/ drivers/ | +30 | 2 replies | |
| 4/20 | drm/amd/display: Hook up DAC to bios_parser_encoder_controldrivers/ | +16 | 0 replies | |
| 5/20 | drm/amd/display: Add SelectCRTC_Source to BIOS parserdrivers/ drivers/ drivers/ +2 more | +215 | 0 replies | |
| 6/20 | drm/amd/display: Get maximum pixel clock from VBIOSdrivers/ drivers/ | +3 | 0 replies | |
| 7/20 | drm/amd/display: Don't use stereo sync and audio on RGB signalsdrivers/ drivers/ drivers/ | +11 | 9 replies | |
| 8/20 | drm/amd/display: Don't try to enable/disable HPD when unavailabledrivers/ | +3 | 0 replies | |
| 9/20 | drm/amd/display: Add concept of analog encodersdrivers/ drivers/ drivers/ +2 more | +44 | 0 replies | |
| 10/20 | drm/amd/display: Implement DCE analog stream encodersdrivers/ drivers/ drivers/ +2 more | +41 | 5 replies | |
| 11/20 | drm/amd/display: Implement DCE analog link encodersdrivers/ drivers/ drivers/ +2 more | +152 | 4 replies | |
| 12/20 | drm/amd/display: Support DAC in dce110_hwseqdrivers/ | +73 | 0 replies | |
| 13/20 | drm/amd/display: Add analog link detectiondrivers/ drivers/ drivers/ +1 more | +95 | 8 replies | |
| 14/20 | drm/amd/display: Poll analog connectorsdrivers/ drivers/ | +66 | 0 replies | |
| 15/20 | drm/amd/display: Add DCE BIOS_SCRATCH_0 registerdrivers/ drivers/ drivers/ +4 more | +12 | 0 replies | |
| 16/20 | drm/amd/display: Make get_support_mask_for_device_id reusabledrivers/ | +7 | 0 replies | |
| 17/20 | drm/amd/display: Add DAC_LoadDetection to BIOS parserdrivers/ drivers/ drivers/ +2 more | +155 | 0 replies | |
| 18/20 | drm/amd/display: Use DAC load detection on analog connectorsdrivers/ drivers/ | +55 | 0 replies | |
| 19/20 | drm/amd/display: Add common modes to analog displays without EDIDdrivers/ | +28 | 0 replies | |
| 20/20 | drm/amdgpu: Use DC by default for Bonairedrivers/ | +0 | 0 replies |
Reviews trailers per patch
1 of 20 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Harry Wentland |
|---|---|
| Series | R-b |
| 1/20 | R-b |
| 2/20 | |
| 3/20 | |
| 4/20 | |
| 5/20 | |
| 6/20 | |
| 7/20 | |
| 8/20 | |
| 9/20 | |
| 10/20 | |
| 11/20 | |
| 12/20 | |
| 13/20 | |
| 14/20 | |
| 15/20 | |
| 16/20 | |
| 17/20 | |
| 18/20 | |
| 19/20 | |
| 20/20 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/20] Analog connector support in DC
This series adds support for analog connectors to DC for DCE6-10. There are two reasons to add this support:
1. GPUs that already use DC by default and have analog connectors. Some Tonga and Hawaii graphics cards in fact have DVI-I connectors, and the analog part doesn't work by default. This functionality regressed when switching from the amdgpu legacy display code to DC.
2. GPUs that don't use amdgpu by default yet. Currently, SI (GFX6) and CIK (GFX7) don't use amdgpu by default yet, and missing analog connector support is cited as one of the main reasons why not.
With this analog support added to DC, we could already fully switch CIK discrete GPUs to use DC and switch them to the amdgpu driver. For GFX7 APUs and SI, further fixes are needed before enabling DC.
Before starting this work, I asked Harry and Alex about how best to do it and we agreed that we'd like to use the VBIOS to set up the DAC. So I used the amdgpu legacy display code as a reference. The first few commits add some minor changes to DC to prepare for supporting analog stream and link encoders, then analog link detection is added along with polling, and finally DAC load detection support, which is useful for old displays and adapters.
Please let me know what you think.
Timur Kristóf (20):
drm/amd/display: Determine DRM connector type more accurately drm/amd/display: Add analog bit to edid_caps drm/amd/display: Introduce MAX_LINK_ENCODERS drm/amd/display: Hook up DAC to bios_parser_encoder_control drm/amd/display: Add SelectCRTC_Source to BIOS parser drm/amd/display: Get maximum pixel clock from VBIOS drm/amd/display: Don't use stereo sync and audio on RGB signals drm/amd/display: Don't try to enable/disable HPD when unavailable drm/amd/display: Add concept of analog encoders drm/amd/display: Implement DCE analog stream encoders drm/amd/display: Implement DCE analog link encoders drm/amd/display: Support DAC in dce110_hwseq drm/amd/display: Add analog link detection drm/amd/display: Poll analog connectors drm/amd/display: Add DCE BIOS_SCRATCH_0 register drm/amd/display: Make get_support_mask_for_device_id reusable drm/amd/display: Add DAC_LoadDetection to BIOS parser drm/amd/display: Use DAC load detection on analog connectors drm/amd/display: Add common modes to analog displays without EDID drm/amdgpu: Use DC by default for Bonaire
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 144 +++++++-- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 5 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 8 + .../gpu/drm/amd/display/dc/bios/bios_parser.c | 95 +++++- .../drm/amd/display/dc/bios/command_table.c | 286 ++++++++++++++++++ .../drm/amd/display/dc/bios/command_table.h | 6 + .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 4 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 8 + .../gpu/drm/amd/display/dc/dc_bios_types.h | 9 + drivers/gpu/drm/amd/display/dc/dc_types.h | 5 + .../drm/amd/display/dc/dce/dce_link_encoder.c | 100 ++++++ .../drm/amd/display/dc/dce/dce_link_encoder.h | 21 +- .../amd/display/dc/dce/dce_stream_encoder.c | 14 + .../amd/display/dc/dce/dce_stream_encoder.h | 5 + .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 75 ++++- .../gpu/drm/amd/display/dc/inc/core_types.h | 8 +- .../gpu/drm/amd/display/dc/inc/hw/hw_shared.h | 24 ++ .../drm/amd/display/dc/inc/hw/link_encoder.h | 2 + drivers/gpu/drm/amd/display/dc/inc/resource.h | 1 + .../amd/display/dc/link/hwss/link_hwss_dio.c | 19 +- .../drm/amd/display/dc/link/link_detection.c | 123 +++++++- .../gpu/drm/amd/display/dc/link/link_dpms.c | 9 +- .../drm/amd/display/dc/link/link_factory.c | 31 ++ .../dc/resource/dce100/dce100_resource.c | 28 +- .../dc/resource/dce110/dce110_resource.c | 2 + .../dc/resource/dce112/dce112_resource.c | 2 + .../dc/resource/dce120/dce120_resource.c | 1 + .../dc/resource/dce60/dce60_resource.c | 26 +- .../dc/resource/dce80/dce80_resource.c | 23 +- .../amd/display/include/bios_parser_types.h | 11 +- .../display/include/grph_object_ctrl_defs.h | 1 + .../drm/amd/display/include/signal_types.h | 5 + 34 files changed, 1027 insertions(+), 76 deletions(-)
Signature · 1 line
2.50.1