Skip to content

Add TLB invalidation abstraction

stuartsummers intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/xe: Add xe_gt_tlb_invalidation_done_handlerdrivers/gpu/drm/xe/xe_gt_tlb_inval.c+30 -170 replies
2/5drm/xe: Decouple TLB invalidations from GTdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_gt.c +15 more+331 -3060 replies
3/5drm/xe: Prep TLB invalidation fence before sendingdrivers/gpu/drm/xe/xe_tlb_inval.c+62 -540 replies
4/5drm/xe: Add helpers to send TLB invalidationsdrivers/gpu/drm/xe/xe_tlb_inval.c+119 -1190 replies
5/5drm/xe: Split TLB invalidation code in frontend and backenddrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_guc_ct.c drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4 more+505 -36613 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchStuart Summers
1/5R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Add TLB invalidation abstraction

This is a new collection of patches from Matt that has been floating around internally and on the mailing list. The goal here is to abstract the actual mechanism of the invalidation from the higher level invalidation triggers (like page table updates).

Most of these were brought in unmodified by Matt, but I've done some minor rebase work here and there and added my signoff where those rebases seemed a little more extensive.

This is built on top of [1] and [2]. I've also brought in [3] and [4] individually from a separate series from Matt.

Stuart

[1] https://patchwork.freedesktop.org/series/151670/#rev1
[2] https://patchwork.freedesktop.org/series/150402/#rev3
[3] https://lists.freedesktop.org/archives/intel-xe/2024-July/041363.html
[4] https://lists.freedesktop.org/archives/intel-xe/2024-July/041364.html

Matthew Brost (5):
drm/xe: Add xe_gt_tlb_invalidation_done_handler drm/xe: Decouple TLB invalidations from GT drm/xe: Prep TLB invalidation fence before sending drm/xe: Add helpers to send TLB invalidations drm/xe: Split TLB invalidation code in frontend and backend

 drivers/gpu/drm/xe/Makefile                   |   5 +-
 drivers/gpu/drm/xe/xe_ggtt.c                  |   6 +-
 drivers/gpu/drm/xe/xe_gt.c                    |   6 +-
 drivers/gpu/drm/xe/xe_gt_tlb_inval.c          | 600 ------------------
 drivers/gpu/drm/xe/xe_gt_tlb_inval.h          |  40 --
 drivers/gpu/drm/xe/xe_gt_tlb_inval_job.h      |  34 -
 drivers/gpu/drm/xe/xe_gt_tlb_inval_types.h    |  64 --
 drivers/gpu/drm/xe/xe_gt_types.h              |   2 +-
 drivers/gpu/drm/xe/xe_guc_ct.c                |   2 +-
 drivers/gpu/drm/xe/xe_guc_tlb_inval.c         | 263 ++++++++
 drivers/gpu/drm/xe/xe_guc_tlb_inval.h         |  19 +
 drivers/gpu/drm/xe/xe_lmtt.c                  |  12 +-
 drivers/gpu/drm/xe/xe_migrate.h               |  10 +-
 drivers/gpu/drm/xe/xe_pt.c                    |  63 +-
 drivers/gpu/drm/xe/xe_svm.c                   |   1 -
 drivers/gpu/drm/xe/xe_tlb_inval.c             | 411 ++++++++++++
 drivers/gpu/drm/xe/xe_tlb_inval.h             |  47 ++
 ..._gt_tlb_inval_job.c => xe_tlb_inval_job.c} | 154 +++--
 drivers/gpu/drm/xe/xe_tlb_inval_job.h         |  34 +
 drivers/gpu/drm/xe/xe_tlb_inval_types.h       | 138 ++++
 drivers/gpu/drm/xe/xe_trace.h                 |  24 +-
 drivers/gpu/drm/xe/xe_vm.c                    |  26 +-
 22 files changed, 1073 insertions(+), 888 deletions(-)
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_inval.c
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_inval.h
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_inval_job.h
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_inval_types.h
 create mode 100644 drivers/gpu/drm/xe/xe_guc_tlb_inval.c
 create mode 100644 drivers/gpu/drm/xe/xe_guc_tlb_inval.h
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval.c
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval.h
 rename drivers/gpu/drm/xe/{xe_gt_tlb_inval_job.c => xe_tlb_inval_job.c} (51%)
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval_job.h
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval_types.h
Signature · 1 line
2.34.1