permit -h/--help-all in more scenarios
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 4 repliesIn review
- v23 patches 0 repliesSuperseded
- v14 patches 13 repliesSuperseded
Changes in v3 from the cover letter
- Rebase on unpublished ua/t1517… v5 (https://lore.kernel.org/git/[email protected]/)
which is rebased on master
- Changed fixup to account for instaweb Perl dependency
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | t1517: fixup for ua/t1517-short-help-testst/ | +7 | 2 replies | |
| 2/3 | parse-options: refactor flags for usage_with_options_internalparse-options.c | +15 | 0 replies | |
| 3/3 | builtin: also setup gently for --help-allbuiltin/ git.c parse-options.c +2 more | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] permit -h/--help-all in more scenarios
Changes from v2:
- Rebase on unpublished ua/t1517… v5 (https://lore.kernel.org/git/[email protected]/)
which is rebased on master
- Changed fixup to account for instaweb Perl dependency
Changes from v1:
- tweak refactor commit message to indicate no behavior is changed;
- use #define'd constants instead of an enum for internal flags;
- drop controversial [4/4]
QQ: Is there a better way to add --cc's to format-patch than grabbing the right folks off threads from lore.kernel.org/git? (I could also grab them out of my mail client.) I assume this is where using tools like b4 starts to really shine? To be clear: I mean CC's _in addition to_ the use of
sendemail.ccCmd = perl contrib/contacts/git-contacts
to keep folks that participated in prior rounds of discussion abreast of the next version.
--------
Original
--------
This series depends on ua/t1517-short-help-tests with some fixes, which show up in the first patch. Start a new topic from the (unpublished) v5 of that branch:
git switch -c topic origin/master
git am ua/t1517-short-help-tests-v5.mbox
Then apply this series.
This series enables --help-all outside of repository contexts, and allows -h with other arguments (without breaking existing ls-remote/grep usage).
It consists of preparatory steps (fixes for a dependency branch; refactoring to make an internal helper's arguments clearer) followed by the main commits.
v1: https://lore.kernel.org/git/[email protected]/
v2: https://lore.kernel.org/git/[email protected]/
Published-as: https://github.com/benknoble/git/tree/help-all-tweaks
D. Ben Knoble (3):
t1517: fixup for ua/t1517-short-help-tests
parse-options: refactor flags for usage_with_options_internal
builtin: also setup gently for --help-all
builtin/merge-recursive.c | 3 ++- git.c | 2 +- parse-options.c | 30 +++++++++++++++++++++++------- t/t1517-outside-repo.sh | 12 +++++++++++- usage.c | 3 ++- 5 files changed, 39 insertions(+), 11 deletions(-)
Diff-intervalle contre v2 :
1: e552926bc4 < -: ---------- t/t1517: automate `git subcmd -h` tests outside a repository
2: 344c7067e6 < -: ---------- t5200: move `update-server-info -h` test from t1517
3: 7a3e0a601d < -: ---------- t1517: fixup for ua/t1517-short-help-tests
-: ---------- > 1: 855931592f t1517: fixup for ua/t1517-short-help-tests
4: db74b1eff7 = 2: 2392039374 parse-options: refactor flags for usage_with_options_internal
5: cb4113f77d ! 3: 4dfc046e6d builtin: also setup gently for --help-all
@@ t/t1517-outside-repo.sh
test_expect_code 129 nongit git $cmd -h >usage &&
test_grep "[Uu]sage: git $cmd " usage
'
-+ test_$expect_outcome "'git $cmd --help-all' outside a repository" '
++ test_$expect_outcome $prereq "'git $cmd --help-all' outside a repository" '
+ test_expect_code 129 nongit git $cmd --help-all >usage &&
+ test_grep "[Uu]sage: git $cmd " usage
+ '
done
- test_expect_success 'prune does not crash with -h' '
+ test_done
## usage.c ##
@@ usage.c: static void show_usage_if_asked_helper(const char *err, ...)base-commit: 866e6a391f466baeeb98bc585845ea638322c04b
prerequisite-patch-id: eb2c55de73b2b733aa0c8c94469a45d9bc361d81
prerequisite-patch-id: 12ddad29e334853cf61c797a2c08302893f4b909
prerequisite-patch-id: 250bae2541030fcdfc5b35ede44c23e1138c7a3c
Signature · 1 line
2.48.1