Skip to content

RFC ftrace,bpf: Use single direct ops for bpf trampolines

Jiri Olsa bpf linux-arm-kernel linux-trace-kernel lkml llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ftrace: Make alloc_and_copy_ftrace_hash direct friendlykernel/trace/ftrace.c+9 -20 replies
2/10ftrace: Add register_ftrace_direct_hash functioninclude/linux/ftrace.h kernel/trace/ftrace.c+130 -00 replies
3/10ftrace: Add unregister_ftrace_direct_hash functioninclude/linux/ftrace.h kernel/trace/ftrace.c+104 -00 replies
4/10ftrace: Add modify_ftrace_direct_hash functioninclude/linux/ftrace.h kernel/trace/ftrace.c+64 -00 replies
5/10ftrace: Export some of hash related functionsinclude/linux/ftrace.h kernel/trace/ftrace.c kernel/trace/trace.h+19 -120 replies
6/10ftrace: Use direct hash interface in direct functionsinclude/linux/ftrace.h kernel/bpf/trampoline.c kernel/trace/ftrace.c +1 more+45 -2290 replies
7/10bpf: Add trampoline ip hash tableinclude/linux/bpf.h kernel/bpf/trampoline.c+24 -130 replies
8/10ftrace: Factor ftrace_ops ops_func interfaceinclude/linux/ftrace.h kernel/bpf/trampoline.c kernel/trace/ftrace.c+28 -60 replies
9/10bpf: Remove ftrace_ops from bpf_trampoline objectinclude/linux/bpf.h kernel/bpf/trampoline.c+10 -250 replies
10/10Revert "ftrace: Store direct called addresses in their ops"include/linux/ftrace.h+0 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/10] ftrace,bpf: Use single direct ops for bpf trampolines

hi,
while poking the multi-tracing interface I ended up with just one ftrace_ops object to attach all trampolines.

This change allows to use less direct API calls during the attachment changes in the future code, so in effect speeding up the attachment.

However having just single ftrace_ops object removes direct_call field from direct_call, which is needed by arm, so I'm not sure it's the right path forward.

Mark, Florent,
any idea how hard would it be to for arm to get rid of direct_call field?

thougts? thanks,
jirka

---
Jiri Olsa (10):
ftrace: Make alloc_and_copy_ftrace_hash direct friendly
ftrace: Add register_ftrace_direct_hash function
ftrace: Add unregister_ftrace_direct_hash function
ftrace: Add modify_ftrace_direct_hash function
ftrace: Export some of hash related functions
ftrace: Use direct hash interface in direct functions
bpf: Add trampoline ip hash table
ftrace: Factor ftrace_ops ops_func interface
bpf: Remove ftrace_ops from bpf_trampoline object Revert "ftrace: Store direct called addresses in their ops"

 include/linux/bpf.h           |   8 +-
 include/linux/ftrace.h        |  51 ++++++++++---
 kernel/bpf/trampoline.c       |  94 +++++++++++++-----------
 kernel/trace/ftrace.c         | 481 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------
 kernel/trace/trace.h          |   8 --
 kernel/trace/trace_selftest.c |   5 +-
 6 files changed, 395 insertions(+), 252 deletions(-)